This is an archive of the discontinued Mercurial Phabricator instance.

Differential D11930

pytype: stop excluding wireprotoserver.py
ClosedPublic

Authored by mharbison72 on Dec 15 2021, 3:47 PM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Commits
rHG81805bba11f9: pytype: stop excluding wireprotoserver.py
Summary

The config entry is a 2 part tuple, which has __iter__():

File "/mnt/c/Users/Matt/hg/mercurial/wireprotoserver.py", line 253, in _availableapis:
    No attribute '__iter__' on Callable[[Any, Any], Any] [attribute-error]
  In Union[Callable[[Any, Any, Any, Any, Any], None], Callable[[Any, Any], Any]]
File "/mnt/c/Users/Matt/hg/mercurial/wireprotoserver.py", line 253, in _availableapis:
    No attribute '__iter__' on Callable[[Any, Any, Any, Any, Any], None] [attribute-error]
  In Union[Callable[[Any, Any, Any, Any, Any], None], Callable[[Any, Any], Any]]

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mharbison72 created this revision.Dec 15 2021, 3:47 PM
Alphare accepted this revision.Dec 17 2021, 6:00 AM
This revision is now accepted and ready to land.Dec 17 2021, 6:00 AM
mharbison72 added a commit: rHG81805bba11f9: pytype: stop excluding wireprotoserver.py.Dec 17 2021, 6:12 AM
Closed by commit rHG81805bba11f9: pytype: stop excluding wireprotoserver.py (authored by mharbison72). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 31523

mercurial/wireprotoserver.py

def _availableapis(repo): def _availableapis(repo):
apis = set() apis = set()
# Registered APIs are made available via config options of the name of # Registered APIs are made available via config options of the name of
# the protocol. # the protocol.
for k, v in API_HANDLERS.items(): for k, v in API_HANDLERS.items():
section, option = v[b'config'] section, option = v[b'config'] # pytype: disable=attribute-error
if repo.ui.configbool(section, option): if repo.ui.configbool(section, option):
apis.add(k) apis.add(k)
return apis return apis
def handlewsgiapirequest(rctx, req, res, checkperm): def handlewsgiapirequest(rctx, req, res, checkperm):
"""Handle requests to /api/*.""" """Handle requests to /api/*."""

tests/test-check-pytype.t

mercurial/repoview.py # [attribute-error] mercurial/repoview.py # [attribute-error]
mercurial/sslutil.py # [attribute-error] mercurial/sslutil.py # [attribute-error]
mercurial/testing/storage.py # tons of [attribute-error] mercurial/testing/storage.py # tons of [attribute-error]
mercurial/ui.py # [attribute-error], [wrong-arg-types] mercurial/ui.py # [attribute-error], [wrong-arg-types]
mercurial/unionrepo.py # ui, svfs, unfiltered [attribute-error] mercurial/unionrepo.py # ui, svfs, unfiltered [attribute-error]
mercurial/utils/memorytop.py # not 3.6 compatible mercurial/utils/memorytop.py # not 3.6 compatible
mercurial/win32.py # [not-callable] mercurial/win32.py # [not-callable]
mercurial/wireprotoframing.py # [unsupported-operands], [attribute-error], [import-error] mercurial/wireprotoframing.py # [unsupported-operands], [attribute-error], [import-error]
mercurial/wireprotoserver.py # line 253, in _availableapis: No attribute '__iter__' on Callable[[Any, Any], Any] [attribute-error]
mercurial/wireprotov1peer.py # [attribute-error] mercurial/wireprotov1peer.py # [attribute-error]
mercurial/wireprotov1server.py # BUG?: BundleValueError handler accesses subclass's attrs mercurial/wireprotov1server.py # BUG?: BundleValueError handler accesses subclass's attrs
TODO: use --no-cache on test server? Caching the files locally helps during TODO: use --no-cache on test server? Caching the files locally helps during
development, but may be a hinderance for CI testing. development, but may be a hinderance for CI testing.
$ pytype -V 3.6 --keep-going --jobs auto mercurial \ $ pytype -V 3.6 --keep-going --jobs auto mercurial \
> -x mercurial/bundlerepo.py \ > -x mercurial/bundlerepo.py \
> -x mercurial/sslutil.py \ > -x mercurial/sslutil.py \
> -x mercurial/testing/storage.py \ > -x mercurial/testing/storage.py \
> -x mercurial/thirdparty \ > -x mercurial/thirdparty \
> -x mercurial/ui.py \ > -x mercurial/ui.py \
> -x mercurial/unionrepo.py \ > -x mercurial/unionrepo.py \
> -x mercurial/utils/memorytop.py \ > -x mercurial/utils/memorytop.py \
> -x mercurial/win32.py \ > -x mercurial/win32.py \
> -x mercurial/wireprotoframing.py \ > -x mercurial/wireprotoframing.py \
> -x mercurial/wireprotoserver.py \
> -x mercurial/wireprotov1peer.py \ > -x mercurial/wireprotov1peer.py \
> -x mercurial/wireprotov1server.py \ > -x mercurial/wireprotov1server.py \
> > $TESTTMP/pytype-output.txt || cat $TESTTMP/pytype-output.txt > > $TESTTMP/pytype-output.txt || cat $TESTTMP/pytype-output.txt
Only show the results on a failure, because the output on success is also Only show the results on a failure, because the output on success is also
voluminous and variable. voluminous and variable.