Page MenuHomePhabricator

pytype: stop excluding ssutil.py
ClosedPublic

Authored by mharbison72 on Dec 15 2021, 3:47 PM.

Details

Summary

Pytype simply can't distinguish the type for this one entry's value from the
other values:

File "/mnt/c/Users/Matt/hg/mercurial/sslutil.py", line 142, in _hostsettings:
    No attribute 'append' on None [attribute-error]
  In Optional[Union[Any, List[nothing], bool, bytes]]
File "/mnt/c/Users/Matt/hg/mercurial/sslutil.py", line 142, in _hostsettings:
    No attribute 'append' on bool [attribute-error]
  In Optional[Union[Any, List[nothing], bool, bytes]]
File "/mnt/c/Users/Matt/hg/mercurial/sslutil.py", line 142, in _hostsettings:
    No attribute 'append' on bytes [attribute-error]
  In Optional[Union[Any, List[nothing], bool, bytes]]
File "/mnt/c/Users/Matt/hg/mercurial/sslutil.py", line 147, in _hostsettings:
    No attribute 'append' on None [attribute-error]
  In Optional[Union[Any, List[Tuple[Any, Any]], bool, bytes]]
File "/mnt/c/Users/Matt/hg/mercurial/sslutil.py", line 147, in _hostsettings:
    No attribute 'append' on bool [attribute-error]
  In Optional[Union[Any, List[Tuple[Any, Any]], bool, bytes]]
File "/mnt/c/Users/Matt/hg/mercurial/sslutil.py", line 147, in _hostsettings:
    No attribute 'append' on bytes [attribute-error]
  In Optional[Union[Any, List[Tuple[Any, Any]], bool, bytes]]

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mharbison72 created this revision.Dec 15 2021, 3:47 PM
Alphare accepted this revision.Dec 17 2021, 6:02 AM
This revision is now accepted and ready to land.Dec 17 2021, 6:02 AM
This revision was automatically updated to reflect the committed changes.