( )⚙ D11931 pytype: stop excluding ssutil.py

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D11931

pytype: stop excluding ssutil.py
ClosedPublic

Authored by mharbison72 on Dec 15 2021, 3:47 PM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Commits
rHG08af0adc235c: pytype: stop excluding ssutil.py
Summary

Pytype simply can't distinguish the type for this one entry's value from the
other values:

File "/mnt/c/Users/Matt/hg/mercurial/sslutil.py", line 142, in _hostsettings:
    No attribute 'append' on None [attribute-error]
  In Optional[Union[Any, List[nothing], bool, bytes]]
File "/mnt/c/Users/Matt/hg/mercurial/sslutil.py", line 142, in _hostsettings:
    No attribute 'append' on bool [attribute-error]
  In Optional[Union[Any, List[nothing], bool, bytes]]
File "/mnt/c/Users/Matt/hg/mercurial/sslutil.py", line 142, in _hostsettings:
    No attribute 'append' on bytes [attribute-error]
  In Optional[Union[Any, List[nothing], bool, bytes]]
File "/mnt/c/Users/Matt/hg/mercurial/sslutil.py", line 147, in _hostsettings:
    No attribute 'append' on None [attribute-error]
  In Optional[Union[Any, List[Tuple[Any, Any]], bool, bytes]]
File "/mnt/c/Users/Matt/hg/mercurial/sslutil.py", line 147, in _hostsettings:
    No attribute 'append' on bool [attribute-error]
  In Optional[Union[Any, List[Tuple[Any, Any]], bool, bytes]]
File "/mnt/c/Users/Matt/hg/mercurial/sslutil.py", line 147, in _hostsettings:
    No attribute 'append' on bytes [attribute-error]
  In Optional[Union[Any, List[Tuple[Any, Any]], bool, bytes]]

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mharbison72 created this revision.Dec 15 2021, 3:47 PM
Alphare accepted this revision.Dec 17 2021, 6:02 AM
This revision is now accepted and ready to land.Dec 17 2021, 6:02 AM
mharbison72 added a commit: rHG08af0adc235c: pytype: stop excluding ssutil.py.Dec 17 2021, 6:12 AM
Closed by commit rHG08af0adc235c: pytype: stop excluding ssutil.py (authored by mharbison72). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/sslutil.py (6 lines)
Mtests/test-check-pytype.t (2 lines)

Diff 31524

mercurial/sslutil.py

if not (fingerprint.startswith((b'sha1:', b'sha256:', b'sha512:'))): if not (fingerprint.startswith((b'sha1:', b'sha256:', b'sha512:'))):
raise error.Abort( raise error.Abort(
_(b'invalid fingerprint for %s: %s') % (bhostname, fingerprint), _(b'invalid fingerprint for %s: %s') % (bhostname, fingerprint),
hint=_(b'must begin with "sha1:", "sha256:", or "sha512:"'), hint=_(b'must begin with "sha1:", "sha256:", or "sha512:"'),
) )
alg, fingerprint = fingerprint.split(b':', 1) alg, fingerprint = fingerprint.split(b':', 1)
fingerprint = fingerprint.replace(b':', b'').lower() fingerprint = fingerprint.replace(b':', b'').lower()
# pytype: disable=attribute-error
# `s` is heterogeneous, but this entry is always a list of tuples
s[b'certfingerprints'].append((alg, fingerprint)) s[b'certfingerprints'].append((alg, fingerprint))
# pytype: enable=attribute-error
# Fingerprints from [hostfingerprints] are always SHA-1. # Fingerprints from [hostfingerprints] are always SHA-1.
for fingerprint in ui.configlist(b'hostfingerprints', bhostname): for fingerprint in ui.configlist(b'hostfingerprints', bhostname):
fingerprint = fingerprint.replace(b':', b'').lower() fingerprint = fingerprint.replace(b':', b'').lower()
# pytype: disable=attribute-error
# `s` is heterogeneous, but this entry is always a list of tuples
s[b'certfingerprints'].append((b'sha1', fingerprint)) s[b'certfingerprints'].append((b'sha1', fingerprint))
# pytype: enable=attribute-error
s[b'legacyfingerprint'] = True s[b'legacyfingerprint'] = True
# If a host cert fingerprint is defined, it is the only thing that # If a host cert fingerprint is defined, it is the only thing that
# matters. No need to validate CA certs. # matters. No need to validate CA certs.
if s[b'certfingerprints']: if s[b'certfingerprints']:
s[b'verifymode'] = ssl.CERT_NONE s[b'verifymode'] = ssl.CERT_NONE
s[b'allowloaddefaultcerts'] = False s[b'allowloaddefaultcerts'] = False

tests/test-check-pytype.t

mercurial/interfaces # No attribute 'capabilities' on peer [attribute-error] mercurial/interfaces # No attribute 'capabilities' on peer [attribute-error]
mercurial/keepalive.py # [attribute-error] mercurial/keepalive.py # [attribute-error]
mercurial/localrepo.py # [attribute-error] mercurial/localrepo.py # [attribute-error]
mercurial/manifest.py # [unsupported-operands], [wrong-arg-types] mercurial/manifest.py # [unsupported-operands], [wrong-arg-types]
mercurial/minirst.py # [unsupported-operands], [attribute-error] mercurial/minirst.py # [unsupported-operands], [attribute-error]
mercurial/pure/osutil.py # [invalid-typevar], [not-callable] mercurial/pure/osutil.py # [invalid-typevar], [not-callable]
mercurial/pure/parsers.py # [attribute-error] mercurial/pure/parsers.py # [attribute-error]
mercurial/repoview.py # [attribute-error] mercurial/repoview.py # [attribute-error]
mercurial/sslutil.py # [attribute-error]
mercurial/testing/storage.py # tons of [attribute-error] mercurial/testing/storage.py # tons of [attribute-error]
mercurial/ui.py # [attribute-error], [wrong-arg-types] mercurial/ui.py # [attribute-error], [wrong-arg-types]
mercurial/unionrepo.py # ui, svfs, unfiltered [attribute-error] mercurial/unionrepo.py # ui, svfs, unfiltered [attribute-error]
mercurial/utils/memorytop.py # not 3.6 compatible mercurial/utils/memorytop.py # not 3.6 compatible
mercurial/win32.py # [not-callable] mercurial/win32.py # [not-callable]
mercurial/wireprotoframing.py # [unsupported-operands], [attribute-error], [import-error] mercurial/wireprotoframing.py # [unsupported-operands], [attribute-error], [import-error]
mercurial/wireprotov1peer.py # [attribute-error] mercurial/wireprotov1peer.py # [attribute-error]
mercurial/wireprotov1server.py # BUG?: BundleValueError handler accesses subclass's attrs mercurial/wireprotov1server.py # BUG?: BundleValueError handler accesses subclass's attrs
> -x mercurial/interfaces \ > -x mercurial/interfaces \
> -x mercurial/keepalive.py \ > -x mercurial/keepalive.py \
> -x mercurial/localrepo.py \ > -x mercurial/localrepo.py \
> -x mercurial/manifest.py \ > -x mercurial/manifest.py \
> -x mercurial/minirst.py \ > -x mercurial/minirst.py \
> -x mercurial/pure/osutil.py \ > -x mercurial/pure/osutil.py \
> -x mercurial/pure/parsers.py \ > -x mercurial/pure/parsers.py \
> -x mercurial/repoview.py \ > -x mercurial/repoview.py \
> -x mercurial/sslutil.py \
> -x mercurial/testing/storage.py \ > -x mercurial/testing/storage.py \
> -x mercurial/thirdparty \ > -x mercurial/thirdparty \
> -x mercurial/ui.py \ > -x mercurial/ui.py \
> -x mercurial/unionrepo.py \ > -x mercurial/unionrepo.py \
> -x mercurial/utils/memorytop.py \ > -x mercurial/utils/memorytop.py \
> -x mercurial/win32.py \ > -x mercurial/win32.py \
> -x mercurial/wireprotoframing.py \ > -x mercurial/wireprotoframing.py \
> -x mercurial/wireprotov1peer.py \ > -x mercurial/wireprotov1peer.py \
> -x mercurial/wireprotov1server.py \ > -x mercurial/wireprotov1server.py \
> > $TESTTMP/pytype-output.txt || cat $TESTTMP/pytype-output.txt > > $TESTTMP/pytype-output.txt || cat $TESTTMP/pytype-output.txt
Only show the results on a failure, because the output on success is also Only show the results on a failure, because the output on success is also
voluminous and variable. voluminous and variable.