( )⚙ D12171 filemerge: put temporary files in single temp dir by default

This is an archive of the discontinued Mercurial Phabricator instance.

filemerge: put temporary files in single temp dir by default
ClosedPublic

Authored by martinvonz on Feb 11 2022, 7:54 PM.

Details

Summary

The feature introduced in D2888 seems like a pure improvement to
me. It makes the names' of temporary file easier to read. Let's have
it always enabled.

I also removed the config option for the path prefix because it
doesn't seem useful. I asked Kyle (the author of the feature) about it
and he couldn't think of a reason to keep it. I suspect it was just
that we to have a config to turn it on/off while it was experimental,
so it might as well be a configurable prefix then.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Feb 11 2022, 7:54 PM

Honestly unless @spectral can tell us why we should keep the config around, I don't see why we shouldn't remove it.

Honestly unless @spectral can tell us why we should keep the config around, I don't see why we shouldn't remove it.

I talked to him about it before I sent the patch. He couldn't think of a reason to keep it. Want me to remove it in this patch? I'm fine with removing it in this patch, in a separate patch, or not at all.

martinvonz updated this revision to Diff 32181.Feb 14 2022, 7:59 PM
marmoute accepted this revision.Feb 15 2022, 5:12 AM
Alphare requested changes to this revision.Feb 15 2022, 7:52 AM

Yeah, let's just remove it completely in this revision. Thanks

This revision now requires changes to proceed.Feb 15 2022, 7:52 AM
martinvonz edited the summary of this revision. (Show Details)Feb 15 2022, 11:59 AM
martinvonz updated this revision to Diff 32218.

Yeah, let's just remove it completely in this revision. Thanks

Done.

This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.
martinvonz updated this revision to Diff 32224.Feb 15 2022, 3:17 PM