( )⚙ D12288 posix: delete Python 2 posixfile()

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D12288

posix: delete Python 2 posixfile()
ClosedPublic

Authored by indygreg on Mar 2 2022, 6:30 PM.

Details

Reviewers
Alphare
Group Reviewers
hg-reviewers
Commits
rHGa2c59b361e0f: posix: delete Python 2 posixfile()
Summary

The comment no longer makes sense since the stdlib open() behaves
the way we want on Python 3. So it was removed.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

indygreg created this revision.Mar 2 2022, 6:30 PM
joerg.sonnenberger added a subscriber: joerg.sonnenberger.Mar 2 2022, 6:46 PM

Please fix the comment to something like: Python 3 file objects set the initial position consistently for append mode and can be used directly or something like that. The current comment doesn't make sense without the context.

Alphare requested changes to this revision.Mar 3 2022, 5:47 AM
This revision now requires changes to proceed.Mar 3 2022, 5:47 AM
indygreg retitled this revision from posix: delete Python 2 support code to posix: delete Python 2 posixfile().Mar 3 2022, 11:09 AM
indygreg edited the summary of this revision. (Show Details)
indygreg updated this revision to Diff 32464.
Alphare accepted this revision.Mar 3 2022, 11:18 AM
This revision is now accepted and ready to land.Mar 3 2022, 11:18 AM
indygreg added a commit: rHGa2c59b361e0f: posix: delete Python 2 posixfile().Mar 3 2022, 11:52 AM
Closed by commit rHGa2c59b361e0f: posix: delete Python 2 posixfile() (authored by indygreg). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/posix.py (17 lines)

Diff 32413

mercurial/posix.py

unlink = os.unlink unlink = os.unlink
rename = os.rename rename = os.rename
removedirs = os.removedirs removedirs = os.removedirs
expandglobs = False expandglobs = False
umask = os.umask(0) umask = os.umask(0)
os.umask(umask) os.umask(umask)
if not pycompat.ispy3:
def posixfile(name, mode='r', buffering=-1):
fp = open(name, mode=mode, buffering=buffering)
# The position when opening in append mode is implementation defined, so
# make it consistent by always seeking to the end.
if 'a' in mode:
fp.seek(0, os.SEEK_END)
return fp
else:
# The underlying file object seeks as required in Python 3: # The underlying file object seeks as required in Python 3:
# https://github.com/python/cpython/blob/v3.7.3/Modules/_io/fileio.c#L474 # https://github.com/python/cpython/blob/v3.7.3/Modules/_io/fileio.c#L474
posixfile = open posixfile = open
def split(p): def split(p):
"""Same as posixpath.split, but faster """Same as posixpath.split, but faster
>>> import posixpath >>> import posixpath
>>> for f in [b'/absolute/path/to/file', >>> for f in [b'/absolute/path/to/file',
... b'relative/path/to/file', ... b'relative/path/to/file',