( )⚙ D12315 setup: drop support for Python 3.5

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D12315

setup: drop support for Python 3.5
ClosedPublic

Authored by indygreg on Mar 2 2022, 9:42 PM.

Download Raw Diff

Tags

None

Subscribers

mercurial-patches

Details

Reviewers

Group Reviewers

Commits

rHG656196c1d442: setup: drop support for Python 3.5

Summary

We talked about this on the mailing list [1] and there seemed to be
agreement that Python 3.5 is effectively dead and no longer worth
supporting.

So this commit changes our minimum version requirement to 3.6.2.

[1] https://www.mercurial-scm.org/pipermail/mercurial-devel/2022-February/147885.html

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Mar 2 2022, 9:42 PM

Herald added a reviewer: hg-reviewers. · View Herald TranscriptMar 2 2022, 9:42 PM

Herald added a subscriber: mercurial-patches. · View Herald Transcript

Alphare accepted this revision.Mar 3 2022, 6:01 AM

This revision is now accepted and ready to land.Mar 3 2022, 6:01 AM

indygreg added a commit: rHG656196c1d442: setup: drop support for Python 3.5.Mar 3 2022, 6:06 AM

Closed by commit rHG656196c1d442: setup: drop support for Python 3.5 (authored by indygreg). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			setup.py (12 lines)

Diff 32450

setup.py

	#			#
	# This is the mercurial setup script.			# This is the mercurial setup script.
	#			#
	# 'python setup.py install', or			# 'python setup.py install', or
	# 'python setup.py --help' for more options			# 'python setup.py --help' for more options
	import os			import os

	# Mercurial will never work on Python 3 before 3.5 due to a lack			# Mercurial can't work on 3.6.0 or 3.6.1 due to a bug in % formatting
	# of % formatting on bytestrings, and can't work on 3.6.0 or 3.6.1			# in bytestrings.
	# due to a bug in % formatting in bytestrings.
	# We cannot support Python 3.5.0, 3.5.1, 3.5.2 because of bug in
	# codecs.escape_encode() where it raises SystemError on empty bytestring
	# bug link: https://bugs.python.org/issue25270
	supportedpy = ','.join(			supportedpy = ','.join(
	[			[
	'>=3.5.3',			'>=3.6.2',
	'!=3.6.0',
	'!=3.6.1',
	]			]
	)			)

	import sys, platform			import sys, platform
	import sysconfig			import sysconfig


	def sysstr(s):			def sysstr(s):