( )⚙ D1238 overlayworkingctx: add _manifest, files(), added(), removed(), modified()

This is an archive of the discontinued Mercurial Phabricator instance.

overlayworkingctx: add _manifest, files(), added(), removed(), modified()
ClosedPublic

Authored by phillco on Oct 26 2017, 12:48 AM.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

phillco updated this revision to Diff 4184.Dec 7 2017, 4:22 PM
durin42 accepted this revision.Dec 7 2017, 4:36 PM
This revision is now accepted and ready to land.Dec 7 2017, 4:36 PM
durin42 added inline comments.Dec 7 2017, 4:37 PM
mercurial/context.py
2061

nit: space after comma

(will fix in flight)

phillco updated this revision to Diff 4203.Dec 7 2017, 4:44 PM
durin42 added inline comments.Dec 7 2017, 5:11 PM
mercurial/context.py
2058

pyflakes noticed this wasn't used. I'm cleaning it up in flight.

2070

Which makes me wonder if this method is dead code now. Could you check and send a follow-up if it is in fact dead? Thanks!

durin42 added inline comments.Dec 7 2017, 5:13 PM
mercurial/context.py
2058

Er, wait. As I look closer: should this be used down on lines 2025 and 2028? Will hold on my push until I hear back.

phillco marked an inline comment as done.Dec 7 2017, 7:06 PM
phillco added inline comments.Dec 7 2017, 7:11 PM
mercurial/context.py
2058

Oops, I think it should be and it got lost along the way. BUT LT ME CONFIRM.

2070

If it is dead I'll just remove it here.

phillco added inline comments.Dec 8 2017, 1:20 AM
mercurial/context.py
2058

*but let me confirm

phillco updated this revision to Diff 4230.Dec 8 2017, 1:37 AM

OK, kept it in and passing to man.setflag().

This revision was automatically updated to reflect the committed changes.