This is an archive of the discontinued Mercurial Phabricator instance.

overlayworkingctx: add ``tomemctx()`` and ``commit()``
ClosedPublic

Authored by phillco on Oct 26 2017, 12:48 AM.

Details

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

phillco updated this revision to Diff 4188.Dec 7 2017, 4:22 PM
phillco updated this revision to Diff 4207.Dec 7 2017, 4:44 PM
phillco updated this revision to Diff 4215.Dec 7 2017, 4:52 PM
durin42 added a subscriber: durin42.Dec 7 2017, 4:54 PM
durin42 added inline comments.
mercurial/context.py
2186

use a tuple instead of a list here

2210

Let's not put this on this object, and instead ask people to do repo.commitctx(ctx.tomemctx(...)) - it lets us keep the surface area of this just a little smaller.

Also, maybe we can then avoid any proliferation of the allowemptycommit logic by gathering that in commitctx?

durin42 requested changes to this revision.Dec 7 2017, 4:56 PM
This revision now requires changes to proceed.Dec 7 2017, 4:56 PM
phillco marked an inline comment as done.Dec 7 2017, 6:59 PM
phillco updated this revision to Diff 4234.Dec 8 2017, 1:37 AM
phillco marked an inline comment as done.Dec 8 2017, 1:38 AM
This revision was automatically updated to reflect the committed changes.