This is an archive of the discontinued Mercurial Phabricator instance.

Differential D12444

test-issue660: test inside a repository, not the test dir
ClosedPublic

Authored by Alphare on Apr 6 2022, 10:10 AM.

Details

Reviewers
marmoute
Group Reviewers
hg-reviewers
Commits
rHG8309c83b6e2c: test-issue660: test inside a repository, not the test dir
rHGc3a0cbefb111: test-issue660: test inside a repository, not the test dir
Summary

This causes an issue with a temporary file showing up in test output
when adding a dirstate-v2 variant of this test.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

Alphare created this revision.Apr 6 2022, 10:10 AM
martinvonz added a subscriber: martinvonz.Apr 7 2022, 8:23 PM

This causes an issue with a temporary file showing up in test output
when adding a dirstate-v2 variant of this test.

Why with dirstate-v2? Why not with dirstate-v1?

Alphare added a comment.Apr 8 2022, 6:08 AM
In D12444#190852, @martinvonz wrote:

This causes an issue with a temporary file showing up in test output
when adding a dirstate-v2 variant of this test.

Why with dirstate-v2? Why not with dirstate-v1?

Because dirstate-v2 uses a docket, whose UUID seed is set in HGTEST_UUIDFILE. run-tests.py creates a UID file at the root of the testdir in this case.

marmoute accepted this revision.Apr 8 2022, 6:38 AM
Alphare added a commit: rHGc3a0cbefb111: test-issue660: test inside a repository, not the test dir.Apr 8 2022, 11:55 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHGc3a0cbefb111: test-issue660: test inside a repository, not the test dir (authored by Alphare). · Explain Why
This revision was automatically updated to reflect the committed changes.
baymax updated this revision to Diff 32916.Apr 8 2022, 12:29 PM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

Revision Contents
Changeset List

PathPackages
Mtests/test-issue660.t (3 lines)

Diff 32916

tests/test-issue660.t

https://bz.mercurial-scm.org/660 and: https://bz.mercurial-scm.org/660 and:
https://bz.mercurial-scm.org/322 https://bz.mercurial-scm.org/322
$ hg init $ hg init repo
$ cd repo
$ echo a > a $ echo a > a
$ mkdir b $ mkdir b
$ echo b > b/b $ echo b > b/b
$ hg commit -A -m "a is file, b is dir" $ hg commit -A -m "a is file, b is dir"
adding a adding a
adding b/b adding b/b
File replaced with directory: File replaced with directory: