This is an archive of the discontinued Mercurial Phabricator instance.

Differential D12466

rust-dirstatemap: remove `__settitem__`
ClosedPublic

Authored by Alphare on Apr 6 2022, 10:12 AM.

Details

Reviewers
marmoute
Group Reviewers
hg-reviewers
Commits
rHG5ca7b5a87523: rust-dirstatemap: remove `__settitem__`
rHGd1b23902629c: rust-dirstatemap: remove `__settitem__`
Summary

This is not used anywhere now.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Alphare created this revision.Apr 6 2022, 10:12 AM
marmoute accepted this revision.Apr 8 2022, 7:31 AM
Alphare added a commit: rHGd1b23902629c: rust-dirstatemap: remove `__settitem__`.Apr 8 2022, 11:56 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHGd1b23902629c: rust-dirstatemap: remove `__settitem__` (authored by Alphare). · Explain Why
This revision was automatically updated to reflect the committed changes.
baymax updated this revision to Diff 32938.Apr 8 2022, 12:29 PM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

baymax updated this revision to Diff 33040.Apr 12 2022, 10:58 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

baymax updated this revision to Diff 33122.Apr 12 2022, 12:06 PM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

Revision Contents
Changeset List

PathPackages
Mmercurial/dirstatemap.py (4 lines)

Diff 32902

mercurial/dirstatemap.py

p1_tracked, p1_tracked,
p2_info, p2_info,
has_meaningful_mtime, has_meaningful_mtime,
parentfiledata, parentfiledata,
) )
def _drop_entry(self, f): def _drop_entry(self, f):
self._map.drop_item_and_copy_source(f) self._map.drop_item_and_copy_source(f)
def __setitem__(self, key, value):
assert isinstance(value, DirstateItem)
self._map.set_dirstate_item(key, value)