This is an archive of the discontinued Mercurial Phabricator instance.

Differential D12469

dirstatemap: move `_refresh_entry` out of the common methods
ClosedPublic

Authored by Alphare on Apr 6 2022, 10:12 AM.

Details

Reviewers
marmoute
Group Reviewers
hg-reviewers
Commits
rHG08163fd98097: dirstatemap: move `_refresh_entry` out of the common methods
rHG1d2a8891139e: dirstatemap: move `_refresh_entry` out of the common methods
Summary

This is only used in the Python implementation now

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Alphare created this revision.Apr 6 2022, 10:12 AM
marmoute accepted this revision.Apr 8 2022, 7:31 AM
Alphare added a commit: rHG1d2a8891139e: dirstatemap: move `_refresh_entry` out of the common methods.Apr 8 2022, 11:57 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHG1d2a8891139e: dirstatemap: move `_refresh_entry` out of the common methods (authored by Alphare). · Explain Why
This revision was automatically updated to reflect the committed changes.
baymax updated this revision to Diff 32941.Apr 8 2022, 12:29 PM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

baymax updated this revision to Diff 33043.Apr 12 2022, 10:58 AM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

baymax updated this revision to Diff 33125.Apr 12 2022, 12:06 PM

✅ refresh by Heptapod after a successful CI run (🐙 💚)

Revision Contents
Changeset List

PathPackages
Mmercurial/dirstatemap.py (4 lines)

Diff 32905

mercurial/dirstatemap.py

def _dirs_decr(self, filename, old_entry=None, remove_variant=False): def _dirs_decr(self, filename, old_entry=None, remove_variant=False):
"""decrement the dirstate counter if applicable """decrement the dirstate counter if applicable
This might be a no-op for some subclasses who deal with directory This might be a no-op for some subclasses who deal with directory
tracking in a different way. tracking in a different way.
""" """
def _refresh_entry(self, f, entry):
"""record updated state of an entry"""
### disk interaction ### disk interaction
def _opendirstatefile(self): def _opendirstatefile(self):
fp, mode = txnutil.trypending(self._root, self._opener, self._filename) fp, mode = txnutil.trypending(self._root, self._opener, self._filename)
if self._pendingmode is not None and self._pendingmode != mode: if self._pendingmode is not None and self._pendingmode != mode:
fp.close() fp.close()
raise error.Abort( raise error.Abort(
_(b'working directory state may be changed parallelly') _(b'working directory state may be changed parallelly')
def set_possibly_dirty(self, filename): def set_possibly_dirty(self, filename):
"""record that the current state of the file on disk is unknown""" """record that the current state of the file on disk is unknown"""
entry = self[filename] entry = self[filename]
entry.set_possibly_dirty() entry.set_possibly_dirty()
self._refresh_entry(filename, entry) self._refresh_entry(filename, entry)
def _refresh_entry(self, f, entry): def _refresh_entry(self, f, entry):
"""record updated state of an entry"""
if not entry.any_tracked: if not entry.any_tracked:
self._map.pop(f, None) self._map.pop(f, None)
def _drop_entry(self, f): def _drop_entry(self, f):
"""remove any entry for file f """remove any entry for file f
This should also drop associated copy information This should also drop associated copy information