( )⚙ D12514 dirstatemap: move `_drop_entry` out of the common methods

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D12514

dirstatemap: move `_drop_entry` out of the common methods
Needs ReviewPublic

Authored by Alphare on Tue, Apr 12, 12:03 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Summary

Only the Python implementation uses it.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Revision Contents
Changeset List

PathPackages
Mmercurial/dirstatemap.py (12 lines)

Diff 33077

mercurial/dirstatemap.py

This might be a no-op for some subclasses who deal with directory This might be a no-op for some subclasses who deal with directory
tracking in a different way. tracking in a different way.
""" """
def _refresh_entry(self, f, entry): def _refresh_entry(self, f, entry):
"""record updated state of an entry""" """record updated state of an entry"""
def _drop_entry(self, f):
"""remove any entry for file f
This should also drop associated copy information
The fact we actually need to drop it is the responsability of the caller"""
### disk interaction ### disk interaction
def _opendirstatefile(self): def _opendirstatefile(self):
fp, mode = txnutil.trypending(self._root, self._opener, self._filename) fp, mode = txnutil.trypending(self._root, self._opener, self._filename)
if self._pendingmode is not None and self._pendingmode != mode: if self._pendingmode is not None and self._pendingmode != mode:
fp.close() fp.close()
raise error.Abort( raise error.Abort(
_(b'working directory state may be changed parallelly') _(b'working directory state may be changed parallelly')
entry.set_possibly_dirty() entry.set_possibly_dirty()
self._refresh_entry(filename, entry) self._refresh_entry(filename, entry)
def _refresh_entry(self, f, entry): def _refresh_entry(self, f, entry):
if not entry.any_tracked: if not entry.any_tracked:
self._map.pop(f, None) self._map.pop(f, None)
def _drop_entry(self, f): def _drop_entry(self, f):
"""remove any entry for file f
This should also drop associated copy information
The fact we actually need to drop it is the responsability of the caller"""
self._map.pop(f, None) self._map.pop(f, None)
self.copymap.pop(f, None) self.copymap.pop(f, None)
if rustmod is not None: if rustmod is not None:
class dirstatemap(_dirstatemapcommon): class dirstatemap(_dirstatemapcommon):