( )⚙ D12537 rust-dirstatemap: stop using `.state` in `is_from_other_parent`

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D12537

rust-dirstatemap: stop using `.state` in `is_from_other_parent`
Needs ReviewPublic

Authored by Alphare on Tue, Apr 12, 12:05 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Summary

This is a deprecated API and will be removed one day.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Revision Contents
Changeset List

PathPackages
Mrust/hg-core/src/dirstate/entry.rs (3 lines)

Diff 33100

rust/hg-core/src/dirstate/entry.rs

self.v1_state().into(), self.v1_state().into(),
self.v1_mode(), self.v1_mode(),
self.v1_size(), self.v1_size(),
self.v1_mtime(), self.v1_mtime(),
) )
} }
pub(crate) fn is_from_other_parent(&self) -> bool { pub(crate) fn is_from_other_parent(&self) -> bool {
self.state() == EntryState::Normal self.flags.contains(Flags::WDIR_TRACKED | Flags::P2_INFO)
&& self.size() == SIZE_FROM_OTHER_PARENT
} }
// TODO: other platforms // TODO: other platforms
#[cfg(unix)] #[cfg(unix)]
pub fn mode_changed( pub fn mode_changed(
&self, &self,
filesystem_metadata: &std::fs::Metadata, filesystem_metadata: &std::fs::Metadata,
) -> bool { ) -> bool {