phabricator: add phabupdate command to update status in batch
ClosedPublic

Authored by quark on Jul 18 2017, 5:10 AM.

Download Raw Diff

Details

Reviewers

durin42

Group Reviewers

hg-reviewers

Commits

rHG6e666cd59879: phabricator: add phabupdate command to update status in batch

Summary

Changing status (accept, etc) on the webpage is not very convenient -
currently there is no way to accept (or abandon etc.) a stack using a single
click or command.

This patch adds a phabupdate command that could be used to change status
in batch. It also supports --comment which will write a comment on the
last revision, which is similar to what we do using emails.

Diff Detail

Repository

rHG Mercurial

Lint

Lint Skipped

Unit

Unit Tests Skipped

Event Timeline

quark created this revision.Jul 18 2017, 5:10 AM

Herald added a reviewer: hg-reviewers. · View Herald TranscriptJul 18 2017, 5:10 AM

Herald added a subscriber: mercurial-devel. · View Herald Transcript

These all look like they're heading the right direction, but I'm not prepared to land them in 4.3-rc. Let's revisit after the freeze.

quark mentioned this in D138: contrib: backport phabricator.py work.Jul 18 2017, 5:24 PM

Revisit after freeze

quark reclaimed this revision.Aug 1 2017, 4:39 PM

quark updated this revision to Diff 557.Aug 4 2017, 3:55 PM

quark updated this revision to Diff 572.Aug 4 2017, 6:13 PM

quark updated this revision to Diff 842.Aug 13 2017, 12:41 AM

queued, thanks

This revision is now accepted and ready to land.Aug 15 2017, 5:43 PM

Closed by commit rHG6e666cd59879: phabricator: add phabupdate command to update status in batch (authored by quark). · Explain WhyAug 15 2017, 5:49 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			contrib/phabricator.py (31 lines)

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	239		Jul 18 2017, 5:10 AM	★	★
Diff 2	557		Aug 4 2017, 3:55 PM	★	★
Diff 3	572		Aug 4 2017, 6:13 PM	★	★
Diff 4	842		Aug 13 2017, 12:41 AM	★	★
Diff 5	962	rHG6e666cd59879427ec5f2a0bebace97fdf9d6395f	Jul 18 2017, 5:05 AM	★	★

Status	Author	Revision
Closed	quark	D127 phabricator: add phabupdate command to update status in batch
Closed	quark	D126 phabricator: add status to revision query language
Closed	quark	D125 phabricator: add a small language to query Differential Revisions
Closed	quark	D124 phabricator: change "readpatch" to be more flexible
Closed	quark	D122 phabricator: add --amend option to phabsend
Closed	quark	D229 phabricator: update diff property even if we choose not to create a new diff
Closed	quark	D121 phabricator: use Phabricator's last node information

Diff 557

contrib/phabricator.py

	# phabricator.py - simple Phabricator integration			# phabricator.py - simple Phabricator integration
	#			#
	# Copyright 2017 Facebook, Inc.			# Copyright 2017 Facebook, Inc.
	#			#
	# This software may be used and distributed according to the terms of the			# This software may be used and distributed according to the terms of the
	# GNU General Public License version 2 or any later version.			# GNU General Public License version 2 or any later version.
	"""simple Phabricator integration			"""simple Phabricator integration

	This extension provides a ``phabsend`` command which sends a stack of			This extension provides a ``phabsend`` command which sends a stack of
	changesets to Phabricator without amending commit messages, and a ``phabread``			changesets to Phabricator without amending commit messages, and a ``phabread``
	command which prints a stack of revisions in a format suitable			command which prints a stack of revisions in a format suitable
	for :hg:`import`.			for :hg:`import`, and a ``phabupdate`` command to update statuses in batch.

	By default, Phabricator requires ``Test Plan`` which might prevent some			By default, Phabricator requires ``Test Plan`` which might prevent some
	changeset from being sent. The requirement could be disabled by changing			changeset from being sent. The requirement could be disabled by changing
	``differential.require-test-plan-field`` config server side.			``differential.require-test-plan-field`` config server side.

	Config::			Config::

	[phabricator]			[phabricator]

	If --stack is given, follow dependencies information and read all patches.			If --stack is given, follow dependencies information and read all patches.
	It is equivalent to the ``:`` operator.			It is equivalent to the ``:`` operator.
	"""			"""
	if opts.get('stack'):			if opts.get('stack'):
	spec = ':(%s)' % spec			spec = ':(%s)' % spec
	drevs = querydrev(repo, spec)			drevs = querydrev(repo, spec)
	readpatch(repo, drevs, ui.write)			readpatch(repo, drevs, ui.write)

				@command('phabupdate',
				[('', 'accept', False, _('accept revisions')),
				('', 'reject', False, _('reject revisions')),
				('', 'abandon', False, _('abandon revisions')),
				('', 'reclaim', False, _('reclaim revisions')),
				('m', 'comment', '', _('comment on the last revision')),
				], _('DREVSPEC [OPTIONS]'))
				def phabupdate(ui, repo, spec, **opts):
				"""update Differential Revision in batch

				DREVSPEC selects revisions. See :hg:`help phabread` for its usage.
				"""
				flags = [n for n in 'accept reject abandon reclaim'.split() if opts.get(n)]
				if len(flags) > 1:
				raise error.Abort(_('%s cannot be used together') % ', '.join(flags))

				actions = []
				for f in flags:
				actions.append({'type': f, 'value': 'true'})

				drevs = querydrev(repo, spec)
				for i, drev in enumerate(drevs):
				if i + 1 == len(drevs) and opts.get('comment'):
				actions.append({'type': 'comment', 'value': opts['comment']})
				if actions:
				params = {'objectIdentifier': drev[r'phid'],
				'transactions': actions}
				callconduit(repo, 'differential.revision.edit', params)

This is an archive of the discontinued Mercurial Phabricator instance.

phabricator: add phabupdate command to update status in batchClosedPublic