My editor was complaining about mismatches between method
signatures.
For methods that are implemented, we change arguments to match
the base. For those that aren't, we use variable arguments
because it shouldn't matter.
durin42 |
hg-reviewers |
My editor was complaining about mismatches between method
signatures.
For methods that are implemented, we change arguments to match
the base. For those that aren't, we use variable arguments
because it shouldn't matter.
Lint Skipped |
Unit Tests Skipped |
For methods that are implemented, we change arguments to match the base.
Alternatively, we could use **kwargs for keywords arguments unused in a method. I think that's a common pattern and it avoids confusing the reader with unused arguments.
The standard we've recently moved to at Google is to allow del foo # unused for unused arguments, so they're forcibly unused, but also still demonstrably passed. It makes things easier overall for various inference tools, and I'd be happy to adopt that in hg too.