Page MenuHomePhabricator
Differential D1384

bundlerepo: rename "bundlefilespos" variable and attribute
ClosedPublic
Actions

Authored by indygreg on Nov 13 2017, 11:59 PM.

Details

Reviewers
dlax
durin42
Group Reviewers
hg-reviewers
Commits
rHGcd4cd7b94ff1: bundlerepo: rename "bundlefilespos" variable and attribute
rHG5ae62363ae55: bundlerepo: rename "bundlefilespos" variable and attribute
Summary

Strictly speaking, this variable tracks offsets within the
changegroup, not the bundle.

While we're here, mark a class attribute as private because
it is.

.. api::

Rename bundlerepo.bundlerepository.bundlefilespos to
_cgfilespos.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Nov 13 2017, 11:59 PM
dlax accepted this revision.Nov 14 2017, 4:20 AM
durin42 accepted this revision.Nov 17 2017, 5:03 PM
This revision is now accepted and ready to land.Nov 17 2017, 5:03 PM
Closed by commit rHG5ae62363ae55: bundlerepo: rename "bundlefilespos" variable and attribute (authored by indygreg). · Explain WhyNov 17 2017, 5:22 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/bundlerepo.py (18 lines)

Diff 3611

View Options

mercurial/bundlerepo.py

Loading...