bundlerepo: rename "bundlefilespos" variable and attribute
ClosedPublic
Actions

Authored by indygreg on Nov 13 2017, 11:59 PM.

Details

Reviewers

dlax
durin42

Group Reviewers

hg-reviewers

Commits

Summary

Strictly speaking, this variable tracks offsets within the
changegroup, not the bundle.

While we're here, mark a class attribute as private because
it is.

.. api::

Rename bundlerepo.bundlerepository.bundlefilespos to
_cgfilespos.

Repository

rHG Mercurial

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

This revision is now accepted and ready to land.Nov 17 2017, 5:03 PM

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			mercurial/bundlerepo.py (18 lines)

Status	Author	Revision
Closed	indygreg	D1394 bundle2: avoid unbound read when seeking
Closed	indygreg	D1393 bundle2: inline struct operations
Closed	indygreg	D1392 bundle2: inline changegroup.readexactly()
Closed	indygreg	D1391 bundle2: inline debug logging
Closed	indygreg	D1390 bundle2: don't use seekable bundle2 parts by default (issue5691)
Closed	indygreg	D1389 bundle2: only seek to beginning of part in bundlerepo
Closed	indygreg	D1388 bundle2: implement consume() API on unbundlepart
Closed	indygreg	D1387 bundle2: implement generic part payload decoder
Closed	indygreg	D1386 bundle2: extract logic for seeking bundle2 part into own class
Closed	indygreg	D1385 perf: add command to benchmark bundle reading
Closed	indygreg	D1384 bundlerepo: rename "bundlefilespos" variable and attribute
Closed	indygreg	D1383 bundlerepo: rename "bundle" arguments to "cgunpacker"
Closed	indygreg	D1382 bundlerepo: use early return