Page MenuHomePhabricator

develwarn: do not emit warning if "config" is unspecified
ClosedPublic

Authored by spectral on Nov 22 2017, 10:35 PM.

Details

Summary

Previously, if the develwarn call site did not specify the category of warning,
and devel.all-warnings was False, it would emit the warning. If it was
intended that this emit a warning if config is unspecified, I would have
expected a comment, so I assumed this was unintentional and am changing the
behavior.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

spectral created this revision.Nov 22 2017, 10:35 PM

(Specifically picked yuja as reviewer since they reviewed the original https://www.mercurial-scm.org/repo/hg/rev/3f33831a9202, so hopefully can tell me whether this was intentional or not and I'm possibly breaking stuff with this change :))

yuja accepted this revision.Nov 24 2017, 10:10 PM

Makes sense. Queued, thanks.

This revision is now accepted and ready to land.Nov 24 2017, 10:10 PM
yuja added a comment.Nov 24 2017, 11:04 PM

(Specifically picked yuja as reviewer since they reviewed the original
https://www.mercurial-scm.org/repo/hg/rev/3f33831a9202,
so hopefully can tell me whether this was intentional

I think it was intentional during the migration to the config gating API,
i.e. no gating unless config= is specified, but the current behavior is
weird, and should be worth breaking the old API.

This revision was automatically updated to reflect the committed changes.