This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1494

develwarn: do not emit warning if "config" is unspecified
ClosedPublic

Authored by spectral on Nov 22 2017, 10:35 PM.

Details

Reviewers
yuja
Group Reviewers
hg-reviewers
Commits
rHGfa2395db68c6: develwarn: do not emit warning if "config" is unspecified
Summary

Previously, if the develwarn call site did not specify the category of warning,
and devel.all-warnings was False, it would emit the warning. If it was
intended that this emit a warning if config is unspecified, I would have
expected a comment, so I assumed this was unintentional and am changing the
behavior.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

spectral created this revision.Nov 22 2017, 10:35 PM
spectral added a comment.Nov 22 2017, 10:36 PM

(Specifically picked yuja as reviewer since they reviewed the original https://www.mercurial-scm.org/repo/hg/rev/3f33831a9202, so hopefully can tell me whether this was intentional or not and I'm possibly breaking stuff with this change :))

yuja accepted this revision.Nov 24 2017, 10:10 PM

Makes sense. Queued, thanks.

This revision is now accepted and ready to land.Nov 24 2017, 10:10 PM
yuja added a comment.Nov 24 2017, 11:04 PM

(Specifically picked yuja as reviewer since they reviewed the original
https://www.mercurial-scm.org/repo/hg/rev/3f33831a9202,
so hopefully can tell me whether this was intentional

I think it was intentional during the migration to the config gating API,
i.e. no gating unless config= is specified, but the current behavior is
weird, and should be worth breaking the old API.

Closed by commit rHGfa2395db68c6: develwarn: do not emit warning if "config" is unspecified (authored by spectral). · Explain WhyNov 24 2017, 11:30 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/ui.py (2 lines)

Diff 3798

mercurial/ui.py

def develwarn(self, msg, stacklevel=1, config=None): def develwarn(self, msg, stacklevel=1, config=None):
"""issue a developer warning message """issue a developer warning message
Use 'stacklevel' to report the offender some layers further up in the Use 'stacklevel' to report the offender some layers further up in the
stack. stack.
""" """
if not self.configbool('devel', 'all-warnings'): if not self.configbool('devel', 'all-warnings'):
if config is not None and not self.configbool('devel', config): if config is None or not self.configbool('devel', config):
return return
msg = 'devel-warn: ' + msg msg = 'devel-warn: ' + msg
stacklevel += 1 # get in develwarn stacklevel += 1 # get in develwarn
if self.tracebackflag: if self.tracebackflag:
util.debugstacktrace(msg, stacklevel, self.ferr, self.fout) util.debugstacktrace(msg, stacklevel, self.ferr, self.fout)
self.log('develwarn', '%s at:\n%s' % self.log('develwarn', '%s at:\n%s' %
(msg, ''.join(util.getstackframes(stacklevel)))) (msg, ''.join(util.getstackframes(stacklevel))))
else: else: