Page MenuHomePhabricator

logtoprocess: add the possibility to not popup a console
Needs RevisionPublic

Authored by lothiraldan on Dec 15 2017, 5:11 AM.

Details

Reviewers
baymax
Group Reviewers
hg-reviewers
Summary

Starting a subprocess on Windows with `DETACHED_PROCESS |
CREATE_NEW_PROCESS_GROUP` as startup info means starting a console GUI window
in almost all cases. If we add a logtoprocess for commandfinish and the prompt
do some hg calls, it will create a short-lived GUI window which is annoying
for end-users.

Creating a subprocess with CREATE_CONSOLE instead seems to no start a
console window but could have other side-effects so it kept under a config
knob.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

lothiraldan created this revision.Dec 15 2017, 5:11 AM
yuja added a subscriber: yuja.Dec 15 2017, 9:01 AM

but could have other side-effects so it kept under a config knob.

My two cents, experimental.* might be better if the config knob exists as
a workaround for an unknown bug.

hgext/logtoprocess.py
66

Can we add CREATE_NEW_PROCESS_GROUP ?

baymax requested changes to this revision.Jan 24 2020, 12:32 PM

There seems to have been no activities on this Diff for the past 3 Months.

By policy, we are automatically moving it out of the need-review state.

Please, move it back to need-review without hesitation if this diff should still be discussed.

:baymax:need-review-idle:

This revision now requires changes to proceed.Jan 24 2020, 12:32 PM