This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1724

githelp: recommend `hg import` for `git am`
ClosedPublic

Authored by indygreg on Dec 19 2017, 12:36 AM.

Details

Reviewers
durin42
Group Reviewers
hg-reviewers
Commits
rHG05b8adf38c55: githelp: recommend `hg import` for `git am`
Summary

This referenced a third party extension. It doesn't feel appropriate
to do that from a core extension. Reference hg import instead.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

indygreg created this revision.Dec 19 2017, 12:36 AM
durin42 added a subscriber: durin42.Dec 20 2017, 8:38 PM

what's wrong with hg import? Doesn't that correctly parses mbox files?

indygreg edited the summary of this revision. (Show Details)Dec 22 2017, 8:39 PM
indygreg retitled this revision from githelp: remove help for `git am` to githelp: recommend `hg import` for `git am`.
indygreg updated this revision to Diff 4592.
durin42 accepted this revision.Jan 18 2018, 2:33 PM
This revision is now accepted and ready to land.Jan 18 2018, 2:33 PM
Closed by commit rHG05b8adf38c55: githelp: recommend `hg import` for `git am` (authored by indygreg). · Explain WhyJan 18 2018, 2:58 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/githelp.py (5 lines)

Diff 4592

hgext/githelp.py

"been deleted.\n\n")) "been deleted.\n\n"))
ui.status((str(cmd)), "\n") ui.status((str(cmd)), "\n")
def am(ui, repo, *args, **kwargs): def am(ui, repo, *args, **kwargs):
cmdoptions=[ cmdoptions=[
] ]
args, opts = parseoptions(ui, cmdoptions, args) args, opts = parseoptions(ui, cmdoptions, args)
cmd = Command('mimport -m') cmd = Command('import')
ui.status(str(cmd), "\n\n") ui.status(str(cmd), "\n")
ui.status(_("note: requires the MboxExtension and the MqExtension.\n"))
def apply(ui, repo, *args, **kwargs): def apply(ui, repo, *args, **kwargs):
cmdoptions = [ cmdoptions = [
('p', 'p', int, ''), ('p', 'p', int, ''),
] ]
args, opts = parseoptions(ui, cmdoptions, args) args, opts = parseoptions(ui, cmdoptions, args)
cmd = Command('import --no-commit') cmd = Command('import --no-commit')