This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1727

githelp: clean up reflog help
ClosedPublic

Authored by indygreg on Dec 19 2017, 12:36 AM.

Details

Reviewers
durin42
pulkit
Group Reviewers
hg-reviewers
Commits
rHGa4cd8f527a7f: githelp: clean up reflog help
Summary

This referenced commands that don't exist in core. The new help
isn't great since it references an experimental extension. But
it is better than nothing.

While we're here, also add test coverage.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Dec 19 2017, 12:36 AM
durin42 accepted this revision.Dec 20 2017, 8:41 PM
This revision is now accepted and ready to land.Dec 20 2017, 8:41 PM
indygreg updated this revision to Diff 4595.Dec 22 2017, 8:39 PM
pulkit accepted this revision.Dec 28 2017, 3:59 PM
durin42 accepted this revision.Jan 18 2018, 2:34 PM
Closed by commit rHGa4cd8f527a7f: githelp: clean up reflog help (authored by indygreg). · Explain WhyJan 18 2018, 2:58 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/githelp.py (4 lines)
Mtests/test-githelp.t (12 lines)

Diff 4924

hgext/githelp.py

cmd = Command('journal') cmd = Command('journal')
if opts.get('all'): if opts.get('all'):
cmd['--all'] = None cmd['--all'] = None
if len(args) > 0: if len(args) > 0:
cmd.append(args[0]) cmd.append(args[0])
ui.status(str(cmd), "\n\n") ui.status(str(cmd), "\n\n")
ui.status(_("note: in hg commits can be deleted from repo but we always" ui.status(_("note: in hg commits can be deleted from repo but we always"
" have backups.\n" " have backups.\n"))
"Please use 'hg backups --restore' or 'hg reset'" +
" to restore from backups.\n"))
def reset(ui, repo, *args, **kwargs): def reset(ui, repo, *args, **kwargs):
cmdoptions = [ cmdoptions = [
('', 'soft', None, ''), ('', 'soft', None, ''),
('', 'hard', None, ''), ('', 'hard', None, ''),
('', 'mixed', None, ''), ('', 'mixed', None, ''),
] ]
args, opts = parseoptions(ui, cmdoptions, args) args, opts = parseoptions(ui, cmdoptions, args)

tests/test-githelp.t

note: Mercurial will commit when complete, as there is no staging area in Mercurial note: Mercurial will commit when complete, as there is no staging area in Mercurial
hg commit --interactive hg commit --interactive
$ hg githelp -- git add --all $ hg githelp -- git add --all
note: use hg addremove to remove files that have been deleted. note: use hg addremove to remove files that have been deleted.
hg add hg add
githelp for reflog
$ hg githelp -- git reflog
hg journal
note: in hg commits can be deleted from repo but we always have backups.
$ hg githelp -- git reflog --all
hg journal --all
note: in hg commits can be deleted from repo but we always have backups.