This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1726

githelp: replace suggestion of `hg record`
ClosedPublic

Authored by indygreg on Dec 19 2017, 12:36 AM.

Details

Reviewers
durin42
pulkit
Group Reviewers
hg-reviewers
Commits
rHGa10a0d5561a9: githelp: replace suggestion of `hg record`
Summary

hg record is deprecated in favor of hg commit --interactive.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Dec 19 2017, 12:36 AM
durin42 accepted this revision.Dec 20 2017, 8:41 PM
This revision is now accepted and ready to land.Dec 20 2017, 8:41 PM
indygreg updated this revision to Diff 4594.Dec 22 2017, 8:39 PM
pulkit accepted this revision.Dec 28 2017, 3:58 PM
durin42 accepted this revision.Jan 18 2018, 2:33 PM
Closed by commit rHGa10a0d5561a9: githelp: replace suggestion of `hg record` (authored by indygreg). · Explain WhyJan 18 2018, 2:58 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/githelp.py (2 lines)
Mtests/test-githelp.t (4 lines)

Diff 4922

hgext/githelp.py

('', 'date', '', ''), ('', 'date', '', ''),
('', 'amend', None, ''), ('', 'amend', None, ''),
('', 'no-edit', None, ''), ('', 'no-edit', None, ''),
] ]
args, opts = parseoptions(ui, cmdoptions, args) args, opts = parseoptions(ui, cmdoptions, args)
cmd = Command('commit') cmd = Command('commit')
if opts.get('patch'): if opts.get('patch'):
cmd = Command('record') cmd = Command('commit --interactive')
if opts.get('amend'): if opts.get('amend'):
if opts.get('no_edit'): if opts.get('no_edit'):
cmd = Command('amend') cmd = Command('amend')
else: else:
cmd['--amend'] = None cmd['--amend'] = None
if opts.get('reuse_message'): if opts.get('reuse_message'):

tests/test-githelp.t

abort: missing git command - usage: hg githelp -- <git command> abort: missing git command - usage: hg githelp -- <git command>
[255] [255]
$ hg githelp -- git $ hg githelp -- git
abort: missing git command - usage: hg githelp -- <git command> abort: missing git command - usage: hg githelp -- <git command>
[255] [255]
githelp on a command with options should succeed githelp on a command with options should succeed
$ hg githelp -- commit -pm "abc" $ hg githelp -- commit -pm "abc"
hg record -m 'abc' hg commit --interactive -m 'abc'
githelp on a command with standalone unrecognized option should succeed with warning githelp on a command with standalone unrecognized option should succeed with warning
$ hg githelp -- commit -p -v $ hg githelp -- commit -p -v
ignoring unknown option -v ignoring unknown option -v
hg record hg commit --interactive
githelp on a command with unrecognized option packed with other options should fail with error githelp on a command with unrecognized option packed with other options should fail with error
$ hg githelp -- commit -pv $ hg githelp -- commit -pv
abort: unknown option v packed with other options abort: unknown option v packed with other options
Please try passing the option as it's own flag: -v Please try passing the option as it's own flag: -v
[255] [255]
githelp for git rebase --skip githelp for git rebase --skip