This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1983

wireprotoserver: remove unused response attribute
ClosedPublic

Authored by indygreg on Feb 1 2018, 6:11 PM.

Details

Reviewers
durin42
Group Reviewers
hg-reviewers
Commits
rHGf084d5131f3e: wireprotoserver: remove unused response attribute
rHG6da3f324b9de: wireprotoserver: remove unused response attribute
Summary

I think the last use of this attribute was removed by 2f8adc60e013
in 2010.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Feb 1 2018, 6:11 PM
durin42 accepted this revision.Feb 1 2018, 6:22 PM
This revision is now accepted and ready to land.Feb 1 2018, 6:22 PM
Closed by commit rHG6da3f324b9de: wireprotoserver: remove unused response attribute (authored by indygreg). · Explain WhyFeb 1 2018, 6:32 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/wireprotoserver.py (1 line)

Diff 5121

mercurial/wireprotoserver.py

chunks.append(pycompat.bytesurl(v)) chunks.append(pycompat.bytesurl(v))
i += 1 i += 1
return ''.join(chunks) return ''.join(chunks)
class webproto(abstractserverproto): class webproto(abstractserverproto):
def __init__(self, req, ui): def __init__(self, req, ui):
self.req = req self.req = req
self.response = ''
self.ui = ui self.ui = ui
self.name = 'http' self.name = 'http'
def getargs(self, args): def getargs(self, args):
knownargs = self._args() knownargs = self._args()
data = {} data = {}
keys = args.split() keys = args.split()
for k in keys: for k in keys: