This is an archive of the discontinued Mercurial Phabricator instance.

wireprotoserver: remove support for do_<command> handlers (API)
ClosedPublic

Authored by indygreg on Feb 1 2018, 6:11 PM.

Details

Summary

Old versions of wire protocol handlers relied on methods
named do_<command> to handle wire protocol commands. The last
definition of these methods on sshserver was removed by
9f6e0e7ef828 ~2 years ago. I think it's time to not support this
mechanism for defining command handlers.

.. api::

sshserver now longers looks for wire protocol command handlers
in methods named do_<command>. Use @wireproto.wireprotocommand
to declare wire protocol command handler functions.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Feb 1 2018, 6:11 PM
durin42 accepted this revision.Feb 1 2018, 6:22 PM
durin42 added a subscriber: durin42.

Fixing a typo (now instead of no) in log message in flight.

This revision is now accepted and ready to land.Feb 1 2018, 6:22 PM
This revision was automatically updated to reflect the committed changes.