This is an archive of the discontinued Mercurial Phabricator instance.

Differential D1987

wireprotoserver: remove sshserver.getarg()
ClosedPublic

Authored by indygreg on Feb 1 2018, 6:11 PM.

Details

Reviewers
durin42
Group Reviewers
hg-reviewers
Commits
rHGc9faf3a2eef1: wireprotoserver: remove sshserver.getarg()
rHG8e949f7f4913: wireprotoserver: remove sshserver.getarg()
Summary

AFAICT the last consumer of this helper method was removed by
d054cc5c7737 in 2010.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Feb 1 2018, 6:11 PM
durin42 accepted this revision.Feb 1 2018, 6:25 PM
This revision is now accepted and ready to land.Feb 1 2018, 6:25 PM
Closed by commit rHG8e949f7f4913: wireprotoserver: remove sshserver.getarg() (authored by indygreg). · Explain WhyFeb 1 2018, 6:32 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/wireprotoserver.py (3 lines)

Diff 5125

mercurial/wireprotoserver.py

val = self.fin.read(int(l)) val = self.fin.read(int(l))
star[arg] = val star[arg] = val
data['*'] = star data['*'] = star
else: else:
val = self.fin.read(int(l)) val = self.fin.read(int(l))
data[arg] = val data[arg] = val
return [data[k] for k in keys] return [data[k] for k in keys]
def getarg(self, name):
return self.getargs(name)[0]
def getfile(self, fpout): def getfile(self, fpout):
self.sendresponse('') self.sendresponse('')
count = int(self.fin.readline()) count = int(self.fin.readline())
while count: while count:
fpout.write(self.fin.read(count)) fpout.write(self.fin.read(count))
count = int(self.fin.readline()) count = int(self.fin.readline())
def redirect(self): def redirect(self):