This is an archive of the discontinued Mercurial Phabricator instance.

Differential D2128

py3: replace file() with open() in test-extdiff.t
ClosedPublic

Authored by pulkit on Feb 11 2018, 7:42 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGd83fc41dabf3: py3: replace file() with open() in test-extdiff.t
Summary

file() is not present in Python 3.
This patch also adds a b'' prefix to make sure we write bytes in Python 3.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.Feb 11 2018, 7:42 AM
Closed by commit rHGd83fc41dabf3: py3: replace file() with open() in test-extdiff.t (authored by pulkit). · Explain WhyFeb 11 2018, 9:05 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-extdiff.t (4 lines)

Diff 5416

tests/test-extdiff.t

Edit with extdiff -p: Edit with extdiff -p:
Prepare custom diff/edit tool: Prepare custom diff/edit tool:
$ cat > 'diff tool.py' << EOT $ cat > 'diff tool.py' << EOT
> #!$PYTHON > #!$PYTHON
> import time > import time
> time.sleep(1) # avoid unchanged-timestamp problems > time.sleep(1) # avoid unchanged-timestamp problems
> file('a/a', 'ab').write('edited\n') > open('a/a', 'ab').write(b'edited\n')
> file('a/b', 'ab').write('edited\n') > open('a/b', 'ab').write(b'edited\n')
> EOT > EOT
#if execbit #if execbit
$ chmod +x 'diff tool.py' $ chmod +x 'diff tool.py'
#endif #endif
will change to /tmp/extdiff.TMP and populate directories a.TMP and a will change to /tmp/extdiff.TMP and populate directories a.TMP and a
and start tool and start tool