This is an archive of the discontinued Mercurial Phabricator instance.

tests/test-convert-git.t
423	To make chr() return bytes, I did chr().encode('latin-1') but there is `UnicodeDecodeError: 'ascii' codec can't decode byte 0x80 in position 0: ordinal not in range(128)` error while writing to file. Python 2 also don't have the encoding argument to open which Python 3 has. Looks like need to write a .py file and execute that.

yuja added inline comments.Feb 12 2018, 5:37 AM

tests/test-convert-git.t
423	Maybe we can steal pycompat.bytechr of py3. It should work on both Pythons.

pulkit edited the summary of this revision. (Show Details)Feb 17 2018, 5:27 AM

pulkit updated this revision to Diff 5808.

yuja accepted this revision.Feb 17 2018, 7:29 AM

This revision is now accepted and ready to land.Feb 17 2018, 7:29 AM

Closed by commit rHG868bb2821e29: py3: replace file() with open() in test-convert-git.t (authored by pulkit). · Explain WhyFeb 17 2018, 7:43 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			tests/test-convert-git.t (4 lines)

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	5396		Feb 11 2018, 7:42 AM	★	★
Diff 2	5808		Feb 17 2018, 5:27 AM	★	★
Diff 3	5810	rHG868bb2821e292cdda6050f229ade1af42d52c9e6	Feb 11 2018, 6:47 AM	★	★

Status	Author	Revision
Closed	pulkit	D2135 py3: use "%d" instead of "%s" for integers
Closed	pulkit	D2134 py3: replace file() with open() in test-contrib.t
Closed	pulkit	D2133 py3: replace file() with open() in test-convert-git.t
Closed	pulkit	D2132 py3: replace file() with open() in test-convert-hg-source.t
Closed	pulkit	D2131 py3: replace file() with open() in test-encoding-align.t
Closed	pulkit	D2130 py3: replace file() with open() in test-encoding.t
Closed	pulkit	D2129 py3: replace file() with open() in test-eol.t
Closed	pulkit	D2128 py3: replace file() with open() in test-extdiff.t
Closed	pulkit	D2127 py3: replace file() with open() in test-fileset.t
Closed	pulkit	D2126 py3: replace file() with open() in test-import-bypass.t
Closed	pulkit	D2125 py3: replace file() with open() in test-import-eol.t
Closed	pulkit	D2124 py3: replace file() with open() in test-import-git.t
Closed	pulkit	D2123 py3: replace file() with open() in test-import.t
Closed	pulkit	D2122 py3: replace file() with open() in test-mactext.t
Closed	pulkit	D2121 py3: replace file() with open() in test-mq-missingfiles.t
Closed	pulkit	D2120 py3: replace file() with open() in test-mq-qimport.t
Closed	pulkit	D2119 py3: replace file() with open() in test-patch-offset.t
Closed	pulkit	D2118 py3: replace file() with open() in test-relink.t
Closed	pulkit	D2117 py3: replace file() with open() in test-subrepo-missing.t
Closed	pulkit	D2116 py3: replace file() with open() in test-tag.t
Closed	pulkit	D2115 py3: replace file() with open() in test-transplant.t
Closed	pulkit	D2114 py3: replace file() with open() in test-walk.t
Closed	pulkit	D2113 py3: replace file() with open() in test-win32text.t
Closed	pulkit	D2112 py3: replace file() with open() in test-convert-p4-filetypes.t
Closed	pulkit	D2111 py3: replace file() with open() in test-convert-mtn.t
Closed	pulkit	D2110 py3: replace file() with open() in test-clone.t
Closed	pulkit	D2109 py3: make sure we return str from __repr__

Diff 5810

tests/test-convert-git.t

	copy-source			copy-source

	test binary conversion (issue1359)			test binary conversion (issue1359)

	$ count=19			$ count=19
	$ mkdir git-repo3			$ mkdir git-repo3
	$ cd git-repo3			$ cd git-repo3
	$ git init-db >/dev/null 2>/dev/null			$ git init-db >/dev/null 2>/dev/null
	$ $PYTHON -c 'file("b", "wb").write("".join([chr(i) for i in range(256)])*16)'			$ $PYTHON -c 'import struct; open("b", "wb").write(b"".join([struct.Struct(">B").pack(i) for i in range(256)])*16)'
				yujaUnsubmitted Not Done We'll need b"' and make `chr()` return bytes. yuja: We'll need b"' and make `chr()` return bytes.
				pulkitAuthorUnsubmitted Not Done To make chr() return bytes, I did chr().encode('latin-1') but there is `UnicodeDecodeError: 'ascii' codec can't decode byte 0x80 in position 0: ordinal not in range(128)` error while writing to file. Python 2 also don't have the encoding argument to open which Python 3 has. Looks like need to write a .py file and execute that. pulkit: To make chr() return bytes, I did chr().encode('latin-1') but there is `UnicodeDecodeError…
				yujaUnsubmitted Not Done Maybe we can steal pycompat.bytechr of py3. It should work on both Pythons. yuja: Maybe we can steal pycompat.bytechr of py3. It should work on both Pythons.
	$ git add b			$ git add b
	$ commit -a -m addbinary			$ commit -a -m addbinary
	$ cd ..			$ cd ..

	convert binary file			convert binary file

	$ hg convert git-repo3 git-repo3-hg			$ hg convert git-repo3 git-repo3-hg
	initializing destination git-repo3-hg repository			initializing destination git-repo3-hg repository
	scanning source...			scanning source...
	sorting...			sorting...
	converting...			converting...
	0 addbinary			0 addbinary
	updating bookmarks			updating bookmarks
	$ cd git-repo3-hg			$ cd git-repo3-hg
	$ hg up -C			$ hg up -C
	1 files updated, 0 files merged, 0 files removed, 0 files unresolved			1 files updated, 0 files merged, 0 files removed, 0 files unresolved
	$ $PYTHON -c 'print len(file("b", "rb").read())'			$ $PYTHON -c 'print len(open("b", "rb").read())'
	4096			4096
	$ cd ..			$ cd ..

	test author vs committer			test author vs committer

	$ mkdir git-repo4			$ mkdir git-repo4
	$ cd git-repo4			$ cd git-repo4
	$ git init-db >/dev/null 2>/dev/null			$ git init-db >/dev/null 2>/dev/null

This is an archive of the discontinued Mercurial Phabricator instance.

py3: replace file() with open() in test-convert-git.tClosedPublic

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 5810

tests/test-convert-git.t

py3: replace file() with open() in test-convert-git.t
ClosedPublic

Revision Contents
Changeset List