This is an archive of the discontinued Mercurial Phabricator instance.

Differential D2132

py3: replace file() with open() in test-convert-hg-source.t
ClosedPublic

Authored by pulkit on Feb 11 2018, 7:42 AM.

Details

Reviewers
yuja
Group Reviewers
hg-reviewers
Commits
rHG3c9f2d4dbb39: py3: replace file() with open() in test-convert-hg-source.t
Summary

file() is not present in Python 3.
It also makes sure we read and write in bytes mode on Python 3.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.Feb 11 2018, 7:42 AM
yuja requested changes to this revision.Feb 11 2018, 9:08 AM
yuja added a subscriber: yuja.

Needs b''.

This revision now requires changes to proceed.Feb 11 2018, 9:08 AM
pulkit edited the summary of this revision. (Show Details)Feb 12 2018, 3:48 AM
pulkit updated this revision to Diff 5481.
yuja accepted this revision.Feb 12 2018, 5:45 AM
This revision is now accepted and ready to land.Feb 12 2018, 5:45 AM
Closed by commit rHG3c9f2d4dbb39: py3: replace file() with open() in test-convert-hg-source.t (authored by pulkit). · Explain WhyFeb 12 2018, 6:07 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-convert-hg-source.t (6 lines)

Diff 5485

tests/test-convert-hg-source.t

o 0 add foo bar o 0 add foo bar
check shamap LF and CRLF handling check shamap LF and CRLF handling
$ cat > rewrite.py <<EOF $ cat > rewrite.py <<EOF
> import sys > import sys
> # Interlace LF and CRLF > # Interlace LF and CRLF
> lines = [(l.rstrip() + ((i % 2) and '\n' or '\r\n')) > lines = [(l.rstrip() + ((i % 2) and b'\n' or b'\r\n'))
> for i, l in enumerate(file(sys.argv[1]))] > for i, l in enumerate(open(sys.argv[1], 'rb'))]
> file(sys.argv[1], 'wb').write(''.join(lines)) > open(sys.argv[1], 'wb').write(b''.join(lines))
> EOF > EOF
$ $PYTHON rewrite.py new/.hg/shamap $ $PYTHON rewrite.py new/.hg/shamap
$ cd orig $ cd orig
$ hg up -qC 1 $ hg up -qC 1
$ echo foo >> foo $ echo foo >> foo
$ hg ci -qm 'change foo again' $ hg ci -qm 'change foo again'
$ hg up -qC 2 $ hg up -qC 2
$ echo foo >> foo $ echo foo >> foo