This is an archive of the discontinued Mercurial Phabricator instance.

Differential D2130

py3: replace file() with open() in test-encoding.t
ClosedPublic

Authored by pulkit on Feb 11 2018, 7:42 AM.

Details

Reviewers
yuja
Group Reviewers
hg-reviewers
Commits
rHG035af48b2903: py3: replace file() with open() in test-encoding.t
Summary

file() is not present in Python 3.
This also makes sure we write things in bytes mode in Python 3.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.Feb 11 2018, 7:42 AM
yuja requested changes to this revision.Feb 11 2018, 9:06 AM
yuja added a subscriber: yuja.

Perhaps these open()s need 'b' because we're testing an encoding issue.

This revision now requires changes to proceed.Feb 11 2018, 9:06 AM
pulkit edited the summary of this revision. (Show Details)Feb 12 2018, 3:48 AM
pulkit updated this revision to Diff 5479.
yuja accepted this revision.Feb 12 2018, 5:45 AM
This revision is now accepted and ready to land.Feb 12 2018, 5:45 AM
Closed by commit rHG035af48b2903: py3: replace file() with open() in test-encoding.t (authored by pulkit). · Explain WhyFeb 12 2018, 6:07 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-encoding.t (6 lines)

Diff 5483

tests/test-encoding.t

adding manifests adding manifests
adding file changes adding file changes
added 2 changesets with 2 changes to 1 files added 2 changesets with 2 changes to 1 files
new changesets 1e78a93102a3:0e5b7e3f9c4a new changesets 1e78a93102a3:0e5b7e3f9c4a
(run 'hg update' to get a working copy) (run 'hg update' to get a working copy)
$ hg co $ hg co
1 files updated, 0 files merged, 0 files removed, 0 files unresolved 1 files updated, 0 files merged, 0 files removed, 0 files unresolved
$ $PYTHON << EOF $ $PYTHON << EOF
> f = file('latin-1', 'w'); f.write("latin-1 e' encoded: \xe9"); f.close() > f = open('latin-1', 'wb'); f.write(b"latin-1 e' encoded: \xe9"); f.close()
> f = file('utf-8', 'w'); f.write("utf-8 e' encoded: \xc3\xa9"); f.close() > f = open('utf-8', 'wb'); f.write(b"utf-8 e' encoded: \xc3\xa9"); f.close()
> f = file('latin-1-tag', 'w'); f.write("\xe9"); f.close() > f = open('latin-1-tag', 'wb'); f.write(b"\xe9"); f.close()
> EOF > EOF
should fail with encoding error should fail with encoding error
$ echo "plain old ascii" > a $ echo "plain old ascii" > a
$ hg st $ hg st
M a M a
? latin-1 ? latin-1