This is an archive of the discontinued Mercurial Phabricator instance.

Differential D2215

httppeer: remove redundant code to fetch capabilities
ClosedPublic

Authored by indygreg on Feb 12 2018, 10:48 PM.

Details

Reviewers
lothiraldan
Group Reviewers
hg-reviewers
Commits
rHGa463f375f021: httppeer: remove redundant code to fetch capabilities
rHGd4012729cfe0: httppeer: remove redundant code to fetch capabilities
Summary

_fetchcaps() is called by httppeer.instance(), which is the only
instantiator of httppeer. Since _fetchcaps() always sets self._caps
and since 197d10e157ce removed the fallback for cases where the
remote doesn't support capabilities, we can remove some dead
code from httppeer.capabilities().

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Feb 12 2018, 10:48 PM
lothiraldan accepted this revision.Feb 13 2018, 3:58 AM
Closed by commit rHGd4012729cfe0: httppeer: remove redundant code to fetch capabilities (authored by indygreg). · Explain WhyFeb 14 2018, 9:05 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/httppeer.py (10 lines)

Diff 5743

mercurial/httppeer.py

def close(self): def close(self):
pass pass
# End of _basepeer interface. # End of _basepeer interface.
# Begin of _basewirepeer interface. # Begin of _basewirepeer interface.
def capabilities(self): def capabilities(self):
if self._caps is None: # self._fetchcaps() should have been called as part of peer
try: # handshake. So self._caps should always be set.
self._fetchcaps() assert self._caps is not None
except error.RepoError:
self._caps = set()
self.ui.debug('capabilities: %s\n' %
(' '.join(self._caps or ['none'])))
return self._caps return self._caps
# End of _basewirepeer interface. # End of _basewirepeer interface.
# look up capabilities only when needed # look up capabilities only when needed
def _fetchcaps(self): def _fetchcaps(self):
self._caps = set(self._call('capabilities').split()) self._caps = set(self._call('capabilities').split())