This is an archive of the discontinued Mercurial Phabricator instance.

narrowcommands: add some missing strkwargs calls for py3
ClosedPublic

Authored by durin42 on Feb 21 2018, 12:42 PM.

Details

Summary
  1. skip-blame because it's just r prefixes

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

durin42 created this revision.Feb 21 2018, 12:42 PM
pulkit added a subscriber: pulkit.Feb 21 2018, 12:56 PM
pulkit added inline comments.
hgext/narrow/narrowcommands.py
146

What about adding r'' prefixes to prevent the the function calls which iterate over all the keys and encode/decode them?

indygreg requested changes to this revision.Feb 21 2018, 10:12 PM
indygreg added a subscriber: indygreg.

Let's do what @pulkit said.

This revision now requires changes to proceed.Feb 21 2018, 10:12 PM
durin42 edited the summary of this revision. (Show Details)Feb 21 2018, 10:24 PM
durin42 updated this revision to Diff 5980.
indygreg accepted this revision.Feb 21 2018, 10:51 PM
This revision is now accepted and ready to land.Feb 21 2018, 10:51 PM
This revision was automatically updated to reflect the committed changes.

This one got pushed with a wrong commit message.