This is an archive of the discontinued Mercurial Phabricator instance.

narrowwirepeer: add some strkwargs to fix a crash on py3
ClosedPublic

Authored by durin42 on Feb 21 2018, 12:41 PM.

Details

Summary
  1. skip-blame because it's just some r prefixes

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Feb 21 2018, 12:41 PM
pulkit added a subscriber: pulkit.Feb 21 2018, 12:54 PM
pulkit added inline comments.
hgext/narrow/narrowwirepeer.py
50

I think better would be to add r'' prefixes as in above two lines as that will save a call to strkwargs.

indygreg requested changes to this revision.Feb 21 2018, 10:08 PM
indygreg added a subscriber: indygreg.
indygreg added inline comments.
hgext/narrow/narrowwirepeer.py
50

I agree.

This revision now requires changes to proceed.Feb 21 2018, 10:08 PM
durin42 marked 2 inline comments as done.Feb 21 2018, 10:24 PM
durin42 edited the summary of this revision. (Show Details)
durin42 updated this revision to Diff 5979.
indygreg accepted this revision.Feb 21 2018, 10:51 PM
This revision is now accepted and ready to land.Feb 21 2018, 10:51 PM
This revision was automatically updated to reflect the committed changes.