This is an archive of the discontinued Mercurial Phabricator instance.

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	5946		Feb 21 2018, 12:41 PM	★	★
Diff 2	5979		Feb 21 2018, 10:24 PM	★	★
Diff 3	5982	rHG87e950a070e6ce3a215b213abf642f7b5a71e325	Feb 21 2018, 11:56 AM	★	★

Status	Author	Revision
Closed	durin42	D2370 narrowchangegroup: remove backwards compatibility with old hg
Closed	durin42	D2369 narrowbundle2: replace map() with equivalent list comprehension
Closed	durin42	D2368 narrowbundle2: this dict contains native strings, look kws up as such
Closed	durin42	D2367 narrowcommands: add some missing strkwargs calls for py3
Closed	durin42	D2366 narrowwirepeer: add some strkwargs to fix a crash on py3
Closed	durin42	D2365 tests: port extension in test-narrow-expanddirstate.t to Python 3
Closed	durin42	D2364 py3: use list comprehensions instead of filter where we need to eagerly filter
Closed	durin42	D2363 narrow: use list comprehension instead of filter for filtering lists

Diff 5979


	def reposetup(repo):			def reposetup(repo):
	def wirereposetup(ui, peer):			def wirereposetup(ui, peer):
	def wrapped(orig, cmd, args, *kwargs):			def wrapped(orig, cmd, args, *kwargs):
	if cmd == 'unbundle':			if cmd == 'unbundle':
	# TODO: don't blindly add include/exclude wireproto			# TODO: don't blindly add include/exclude wireproto
	# arguments to unbundle.			# arguments to unbundle.
	include, exclude = repo.narrowpats			include, exclude = repo.narrowpats
	kwargs["includepats"] = ','.join(include)			kwargs[r"includepats"] = ','.join(include)
	kwargs["excludepats"] = ','.join(exclude)			kwargs[r"excludepats"] = ','.join(exclude)
	return orig(cmd, args, *kwargs)			return orig(cmd, args, *kwargs)
				pulkitUnsubmitted Done I think better would be to add r'' prefixes as in above two lines as that will save a call to strkwargs. pulkit: I think better would be to add r'' prefixes as in above two lines as that will save a call to…
				indygregUnsubmitted Done I agree. indygreg: I agree.
	extensions.wrapfunction(peer, '_calltwowaystream', wrapped)			extensions.wrapfunction(peer, '_calltwowaystream', wrapped)
	hg.wirepeersetupfuncs.append(wirereposetup)			hg.wirepeersetupfuncs.append(wirereposetup)