This is an archive of the discontinued Mercurial Phabricator instance.

sshpeer: rename _recv and _send to _readframed and _writeframed
ClosedPublic

Authored by indygreg on Feb 21 2018, 5:07 PM.

Details

Summary

Because it is reading and writing a chunk of data with a well-defined
size. "recv" and "send" make it sound like things are a direct proxy to
the underlying pipe, which they aren't.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

indygreg created this revision.Feb 21 2018, 5:07 PM
yuja accepted this revision.Feb 22 2018, 9:05 AM
This revision is now accepted and ready to land.Feb 22 2018, 9:05 AM
This revision was automatically updated to reflect the committed changes.