This is an archive of the discontinued Mercurial Phabricator instance.

sshpeer: factor out code for creating peers from pipes
ClosedPublic

Authored by indygreg on Feb 22 2018, 7:50 PM.

Details

Summary

An upcoming commit will want to instantiate an SSH peer via
an alternate mechanism that doesn't require running a new
ssh command. To facilitate that, we extract the code for
creating a peer from pipes to its own function.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Feb 22 2018, 7:50 PM
dhduvall added inline comments.
mercurial/sshpeer.py
537

That second path should be proc?

indygreg updated this revision to Diff 6018.Feb 23 2018, 11:29 AM
yuja accepted this revision.Mar 1 2018, 5:54 AM
This revision is now accepted and ready to land.Mar 1 2018, 5:54 AM
This revision was automatically updated to reflect the committed changes.