This is an archive of the discontinued Mercurial Phabricator instance.

Differential D2484

wireprotoserver: identify requests via version 2 of SSH protocol as such
ClosedPublic

Authored by indygreg on Feb 27 2018, 6:49 PM.

Details

Reviewers
durin42
Group Reviewers
hg-reviewers
Commits
rHGaf0d38f015bb: wireprotoserver: identify requests via version 2 of SSH protocol as such
Summary

The protocol handler needs to advertise itself as version 2 in order
for a future feature to work.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Feb 27 2018, 6:49 PM
indygreg updated this revision to Diff 6334.Mar 2 2018, 9:50 AM
durin42 accepted this revision.Mar 2 2018, 7:04 PM
This revision is now accepted and ready to land.Mar 2 2018, 7:04 PM
Closed by commit rHGaf0d38f015bb: wireprotoserver: identify requests via version 2 of SSH protocol as such (authored by indygreg). · Explain WhyMar 2 2018, 7:13 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/wireprotoserver.py (4 lines)

Diff 6409

mercurial/wireprotoserver.py

def client(self): def client(self):
client = encoding.environ.get('SSH_CLIENT', '').split(' ', 1)[0] client = encoding.environ.get('SSH_CLIENT', '').split(' ', 1)[0]
return 'remote:ssh:' + client return 'remote:ssh:' + client
class sshv2protocolhandler(sshv1protocolhandler): class sshv2protocolhandler(sshv1protocolhandler):
"""Protocol handler for version 2 of the SSH protocol.""" """Protocol handler for version 2 of the SSH protocol."""
@property
def name(self):
return wireprototypes.SSHV2
def _runsshserver(ui, repo, fin, fout, ev): def _runsshserver(ui, repo, fin, fout, ev):
# This function operates like a state machine of sorts. The following # This function operates like a state machine of sorts. The following
# states are defined: # states are defined:
# #
# protov1-serving # protov1-serving
# Server is in protocol version 1 serving mode. Commands arrive on # Server is in protocol version 1 serving mode. Commands arrive on
# new lines. These commands are processed in this state, one command # new lines. These commands are processed in this state, one command
# after the other. # after the other.