This is an archive of the discontinued Mercurial Phabricator instance.

wireproto: don't expose changegroupsubset capability if not available
ClosedPublic

Authored by indygreg on Feb 27 2018, 6:50 PM.

Details

Summary

We just marked the changegroupsubset command as only available to
version 1 of the wire transports. There is a capability of the same
name of the command that indicates if the command is supported.

This commit teaches the capabilities code to conditionally emit that
capability depending on whether the command is available for the
current transport.

Most test output is reordering of capabilities. But the limited tests
for version 2 of the SSH protocol do show the capability disappearing.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Feb 27 2018, 6:50 PM
indygreg updated this revision to Diff 6339.Mar 2 2018, 9:50 AM
indygreg updated this revision to Diff 6405.Mar 2 2018, 6:55 PM
durin42 accepted this revision.Mar 2 2018, 7:05 PM
This revision is now accepted and ready to land.Mar 2 2018, 7:05 PM
This revision was automatically updated to reflect the committed changes.