( )⚙ D2435 commitextras: fix on Python 3 by using sysstrs for __dict__ ops

This is an archive of the discontinued Mercurial Phabricator instance.

commitextras: fix on Python 3 by using sysstrs for __dict__ ops
ClosedPublic

Authored by durin42 on Feb 25 2018, 10:49 PM.

Details

Summary

I'm dubious of the dict shenanigans in use here, but lack the
enthusiasm for figuring out why that was done right now.

  1. skip-blame just some r prefixes

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

durin42 created this revision.Feb 25 2018, 10:49 PM
indygreg accepted this revision.Feb 26 2018, 12:36 AM
indygreg added a subscriber: indygreg.

That __dict__ usage is... special.

This revision is now accepted and ready to land.Feb 26 2018, 12:36 AM
This revision was automatically updated to reflect the committed changes.