( )⚙ D2541 verify: fix exception formatting bug in Python 3

This is an archive of the discontinued Mercurial Phabricator instance.

verify: fix exception formatting bug in Python 3
ClosedPublic

Authored by durin42 on Mar 2 2018, 9:50 AM.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Mar 2 2018, 9:50 AM
pulkit accepted this revision.Mar 2 2018, 10:20 AM
yuja requested changes to this revision.Mar 2 2018, 10:55 AM
yuja added a subscriber: yuja.

According to 12998fd17fbc, the original intent was to use repr() if str(inst) was empty.

Needs pycompat.byterepr(inst) if util.forcebytestr(inst) is empty.

This revision now requires changes to proceed.Mar 2 2018, 10:55 AM
durin42 updated this revision to Diff 6364.Mar 2 2018, 12:10 PM
yuja accepted this revision.Mar 2 2018, 2:34 PM
yuja added inline comments.
mercurial/verify.py
73–76

s/inst/fmsg/ and queued, thanks.

This revision is now accepted and ready to land.Mar 2 2018, 2:34 PM
This revision was automatically updated to reflect the committed changes.