This is an archive of the discontinued Mercurial Phabricator instance.

tests: add tests about diff quality
ClosedPublic

Authored by quark on Mar 3 2018, 3:07 PM.

Details

Summary

These show the differences between bdiff and xdiff.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

quark created this revision.Mar 3 2018, 3:07 PM
quark updated this revision to Diff 6468.Mar 3 2018, 3:20 PM
indygreg requested changes to this revision.Mar 3 2018, 4:24 PM
indygreg added a subscriber: indygreg.

Can you please fix the Python 3 compatibility issues? If you want to push back, we can do it as a follow-up.

tests/test-diff-antipatience.t
15

This should be 'wb' for Python 3 compatibility. And it should use b'' literals.

This revision now requires changes to proceed.Mar 3 2018, 4:24 PM
quark updated this revision to Diff 6481.Mar 3 2018, 4:31 PM
quark marked an inline comment as done.Mar 3 2018, 4:35 PM
durin42 accepted this revision.Mar 3 2018, 6:12 PM
This revision was automatically updated to reflect the committed changes.