This is an archive of the discontinued Mercurial Phabricator instance.

Differential D2903

utils: add isauthorwellformed function
AbandonedPublic

Authored by sheehan on Mar 20 2018, 1:56 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Summary

Adds a function to determine if an author field is formatted
correctly (ie "Contributor Name <something@something.com>")

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

sheehan created this revision.Mar 20 2018, 1:56 PM
lothiraldan added subscribers: pulkit, lothiraldan.Mar 21 2018, 4:57 AM

We are trying to slim down util.py, do you think it would be possible to put it in a new module, something like utils/authorutil.py?

@pulkit do we need the b prefix when calling re.compile for Python3 compat?

pulkit added a comment.Mar 21 2018, 7:03 AM
In D2903#46731, @lothiraldan wrote:

@pulkit do we need the b prefix when calling re.compile for Python3 compat?

Not necessary, transformer will do that but it will be good adding the b'' prefix.

yuja added a subscriber: yuja.Mar 21 2018, 9:03 AM

We are trying to slim down util.py, do you think it would be possible to
put it in a new module, something like utils/authorutil.py?

+1. It could be utils/stringutil.py if "author" is too specific.

Some potential functions that should be moved:

  • stringmatcher() (if "stringutil")
  • shortuser()
  • emailuser()
  • email()
  • ellipsis() (if "stringutil")
  • escapestr() (if "stringutil")
  • unescapestr() (if "stringutil")
  • forcebytestr() (if "stringutil")
  • uirepr() (maybe if "stringutil")
  • wrap() (maybe if "stringutil")
yuja added a comment.Mar 21 2018, 9:12 AM

Not necessary, transformer will do that but it will be good adding the b'' prefix.

br'' is preferred here because Python 3 is getting stricter on invalid \<char>
escapes.

lothiraldan added a comment.Mar 21 2018, 9:15 AM
In D2903#46735, @yuja wrote:

We are trying to slim down util.py, do you think it would be possible to
put it in a new module, something like utils/authorutil.py?

+1. It could be utils/stringutil.py if "author" is too specific.
Some potential functions that should be moved:

  • stringmatcher() (if "stringutil")
  • shortuser()
  • emailuser()
  • email()
  • ellipsis() (if "stringutil")
  • escapestr() (if "stringutil")
  • unescapestr() (if "stringutil")
  • forcebytestr() (if "stringutil")
  • uirepr() (maybe if "stringutil")
  • wrap() (maybe if "stringutil")

👍 on stringutil

sheehan abandoned this revision.Mar 31 2018, 10:03 AM

Abandoning, this was landed as another differential.

Revision Contents
Changeset List

PathPackages
Mmercurial/util.py (6 lines)

Diff 7162

mercurial/util.py

def email(author): def email(author):
'''get email of author.''' '''get email of author.'''
r = author.find('>') r = author.find('>')
if r == -1: if r == -1:
r = None r = None
return author[author.find('<') + 1:r] return author[author.find('<') + 1:r]
_correctauthorformat = re.compile('^[^<]+\s\<[^<>]+@[^<>]+\>$')
def isauthorwellformed(author):
'''Return True if the author field is well formed
(ie "Contributor Name <contrib@email.dom>")'''
return bool(_correctauthorformat.match(author))
def ellipsis(text, maxlength=400): def ellipsis(text, maxlength=400):
"""Trim string to at most maxlength (default: 400) columns in display.""" """Trim string to at most maxlength (default: 400) columns in display."""
return encoding.trim(text, maxlength, ellipsis='...') return encoding.trim(text, maxlength, ellipsis='...')
def unitcountfn(*unittable): def unitcountfn(*unittable):
'''return a function that renders a readable count of some quantity''' '''return a function that renders a readable count of some quantity'''
def go(count): def go(count):