( )⚙ D2927 localrepo: make filterpats private (API)

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D2927

localrepo: make filterpats private (API)
ClosedPublic

Authored by indygreg on Mar 21 2018, 8:12 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHGdb90a5793103: localrepo: make filterpats private (API)
Summary

I'm not sure why this is available on the public API. AFAICT it isn't
used outside of the class.

.. api::

localrepo.localrepository.filterpats was renamed to
localrepo.localrepository._filterpats.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Mar 21 2018, 8:12 PM
pulkit accepted this revision.Mar 28 2018, 6:04 AM
Closed by commit rHGdb90a5793103: localrepo: make filterpats private (API) (authored by indygreg). · Explain WhyMar 28 2018, 6:06 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/localrepo.py (8 lines)

Diff 7350

mercurial/localrepo.py

self._applyopenerreqs() self._applyopenerreqs()
if create: if create:
self._writerequirements() self._writerequirements()
self._dirstatevalidatewarned = False self._dirstatevalidatewarned = False
self._branchcaches = {} self._branchcaches = {}
self._revbranchcache = None self._revbranchcache = None
self.filterpats = {} self._filterpats = {}
self._datafilters = {} self._datafilters = {}
self._transref = self._lockref = self._wlockref = None self._transref = self._lockref = self._wlockref = None
# A cache for various files under .hg/ that tracks file changes, # A cache for various files under .hg/ that tracks file changes,
# (used by the filecache decorator) # (used by the filecache decorator)
# #
# Maps a property name to its util.filecacheentry # Maps a property name to its util.filecacheentry
self._filecache = {} self._filecache = {}
def getcwd(self): def getcwd(self):
return self.dirstate.getcwd() return self.dirstate.getcwd()
def pathto(self, f, cwd=None): def pathto(self, f, cwd=None):
return self.dirstate.pathto(f, cwd) return self.dirstate.pathto(f, cwd)
def _loadfilter(self, filter): def _loadfilter(self, filter):
if filter not in self.filterpats: if filter not in self._filterpats:
l = [] l = []
for pat, cmd in self.ui.configitems(filter): for pat, cmd in self.ui.configitems(filter):
if cmd == '!': if cmd == '!':
continue continue
mf = matchmod.match(self.root, '', [pat]) mf = matchmod.match(self.root, '', [pat])
fn = None fn = None
params = cmd params = cmd
for name, filterfn in self._datafilters.iteritems(): for name, filterfn in self._datafilters.iteritems():
if cmd.startswith(name): if cmd.startswith(name):
fn = filterfn fn = filterfn
params = cmd[len(name):].lstrip() params = cmd[len(name):].lstrip()
break break
if not fn: if not fn:
fn = lambda s, c, **kwargs: procutil.filter(s, c) fn = lambda s, c, **kwargs: procutil.filter(s, c)
# Wrap old filters not supporting keyword arguments # Wrap old filters not supporting keyword arguments
if not pycompat.getargspec(fn)[2]: if not pycompat.getargspec(fn)[2]:
oldfn = fn oldfn = fn
fn = lambda s, c, **kwargs: oldfn(s, c) fn = lambda s, c, **kwargs: oldfn(s, c)
l.append((mf, fn, params)) l.append((mf, fn, params))
self.filterpats[filter] = l self._filterpats[filter] = l
return self.filterpats[filter] return self._filterpats[filter]
def _filter(self, filterpats, filename, data): def _filter(self, filterpats, filename, data):
for mf, fn, cmd in filterpats: for mf, fn, cmd in filterpats:
if mf(filename): if mf(filename):
self.ui.debug("filtering %s through %s\n" % (filename, cmd)) self.ui.debug("filtering %s through %s\n" % (filename, cmd))
data = fn(data, cmd, ui=self.ui, repo=self, filename=filename) data = fn(data, cmd, ui=self.ui, repo=self, filename=filename)
break break