Page MenuHomePhabricator

stringutil: move person function from templatefilters
ClosedPublic

Authored by sheehan on Mar 27 2018, 12:04 PM.

Details

Summary

Move the person function from template filters to the stringutil
module, so it can be reused in the mailmap template function.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

sheehan created this revision.Mar 27 2018, 12:04 PM
av6 requested changes to this revision.Mar 28 2018, 1:10 AM
av6 added a subscriber: av6.
av6 added inline comments.
mercurial/templatefilters.py
293–294

Don't remove this docstring (at least not completely), its first paragraph goes to hg help templates.

This revision now requires changes to proceed.Mar 28 2018, 1:10 AM
sheehan marked an inline comment as done.Mar 29 2018, 10:10 AM
sheehan updated this revision to Diff 7360.
yuja accepted this revision.Mar 30 2018, 8:35 AM
yuja added a comment.Mar 30 2018, 8:36 AM

Queued, thanks. I've adjusted the location of codes so the author-related
functions are grouped.

This revision was automatically updated to reflect the committed changes.