This is an archive of the discontinued Mercurial Phabricator instance.

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	7343		Mar 27 2018, 12:04 PM	★	★
Diff 2	7359		Mar 29 2018, 10:10 AM	★	★
Diff 3	7379	rHGf8e1f48de118e71c4be26d7f9e8953f65979b60c	Mar 22 2018, 9:48 AM	★	★

	Status	Author	Revision
	Closed	sheehan	D2960 stringutil: move person function from templatefilters
	Closed	sheehan	D2959 stringutil: add isauthorwellformed function

Diff 7379

mercurial/utils/stringutil.py


	def email(author):			def email(author):
	'''get email of author.'''			'''get email of author.'''
	r = author.find('>')			r = author.find('>')
	if r == -1:			if r == -1:
	r = None			r = None
	return author[author.find('<') + 1:r]			return author[author.find('<') + 1:r]

				_correctauthorformat = remod.compile(br'^[^<]+\s\<[^<>]+@[^<>]+\>$')

				def isauthorwellformed(author):
				'''Return True if the author field is well formed
				(ie "Contributor Name <contrib@email.dom>")

				>>> isauthorwellformed(b'Good Author <good@author.com>')
				True
				>>> isauthorwellformed(b'Author <good@author.com>')
				True
				>>> isauthorwellformed(b'Bad Author')
				False
				>>> isauthorwellformed(b'Bad Author <author@author.com')
				False
				>>> isauthorwellformed(b'Bad Author author@author.com')
				False
				>>> isauthorwellformed(b'<author@author.com>')
				False
				>>> isauthorwellformed(b'Bad Author <author>')
				False
				'''
				return _correctauthorformat.match(author) is not None

	def ellipsis(text, maxlength=400):			def ellipsis(text, maxlength=400):
	"""Trim string to at most maxlength (default: 400) columns in display."""			"""Trim string to at most maxlength (default: 400) columns in display."""
	return encoding.trim(text, maxlength, ellipsis='...')			return encoding.trim(text, maxlength, ellipsis='...')

	def escapestr(s):			def escapestr(s):
	# call underlying function of s.encode('string_escape') directly for			# call underlying function of s.encode('string_escape') directly for
	# Python 3 compatibility			# Python 3 compatibility
	return codecs.escape_encode(s)[0]			return codecs.escape_encode(s)[0]
	'0': False, 'no': False, 'false': False, 'off': False,			'0': False, 'no': False, 'false': False, 'off': False,
	'never': False}			'never': False}

	def parsebool(s):			def parsebool(s):
	"""Parse s into a boolean.			"""Parse s into a boolean.

	If s is not a valid boolean, returns None.			If s is not a valid boolean, returns None.
	"""			"""
	return _booleans.get(s.lower(), None)			return _booleans.get(s.lower(), None)
				av6Unsubmitted Done Nit: `is not None` is more pythonic. av6: Nit: `is not None` is more pythonic.
				yujaUnsubmitted Done Nit: add br'' for Python 3 compatibility. yuja: Nit: add br'' for Python 3 compatibility.
				yujaUnsubmitted Done b'' for Python 3 compatibility. yuja: b'' for Python 3 compatibility.

This is an archive of the discontinued Mercurial Phabricator instance.

stringutil: add isauthorwellformed functionClosedPublic

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 7379

mercurial/utils/stringutil.py

stringutil: add isauthorwellformed function
ClosedPublic

Revision Contents
Changeset List