This is an archive of the discontinued Mercurial Phabricator instance.

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	7343		Mar 27 2018, 12:04 PM	★	★
Diff 2	7359		Mar 29 2018, 10:10 AM	★	★
Diff 3	7379	rHGf8e1f48de118e71c4be26d7f9e8953f65979b60c	Mar 22 2018, 9:48 AM	★	★

	Status	Author	Revision
	Closed	sheehan	D2960 stringutil: move person function from templatefilters
	Closed	sheehan	D2959 stringutil: add isauthorwellformed function

Diff 7343

	'never': False}			'never': False}

	def parsebool(s):			def parsebool(s):
	"""Parse s into a boolean.			"""Parse s into a boolean.

	If s is not a valid boolean, returns None.			If s is not a valid boolean, returns None.
	"""			"""
	return _booleans.get(s.lower(), None)			return _booleans.get(s.lower(), None)

				_correctauthorformat = remod.compile('^[^<]+\s\<[^<>]+@[^<>]+\>$')
				yujaUnsubmitted Done Nit: add br'' for Python 3 compatibility. yuja: Nit: add br'' for Python 3 compatibility.
				def isauthorwellformed(author):
				'''Return True if the author field is well formed
				(ie "Contributor Name <contrib@email.dom>")

				>>> isauthorwellformed('Good Author <good@author.com>')
				yujaUnsubmitted Done b'' for Python 3 compatibility. yuja: b'' for Python 3 compatibility.
				True
				>>> isauthorwellformed('Author <good@author.com>')
				True
				>>> isauthorwellformed('Bad Author')
				False
				>>> isauthorwellformed('Bad Author <author@author.com')
				False
				>>> isauthorwellformed('Bad Author author@author.com')
				False
				>>> isauthorwellformed('<author@author.com>')
				False
				>>> isauthorwellformed('Bad Author <author>')
				False
				'''
				return bool(_correctauthorformat.match(author))
				av6Unsubmitted Done Nit: `is not None` is more pythonic. av6: Nit: `is not None` is more pythonic.