This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3073

hgweb: drop support for "manifest" parameter
ClosedPublic

Authored by martinvonz on Apr 4 2018, 12:41 PM.

Details

Reviewers
durin42
Group Reviewers
hg-reviewers
Commits
rHG44f3b60deafb: hgweb: drop support for "manifest" parameter
Summary

AFAICT (but note that this is the first time I look at hgweb code),
the "mercurial" query parameter was removed from rendered pages in
36fa5db79dd5 (hgweb: convert gitweb to NWI, 2006-10-05). Search for
"manifest=" in that diff to see why I think it was removed. It's about
time we stop looking for the parameter in requests.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

martinvonz created this revision.Apr 4 2018, 12:41 PM
durin42 accepted this revision.Apr 4 2018, 2:18 PM
durin42 added a subscriber: durin42.

killing this with fire

This revision is now accepted and ready to land.Apr 4 2018, 2:18 PM
Closed by commit rHG44f3b60deafb: hgweb: drop support for "manifest" parameter (authored by martinvonz). · Explain WhyApr 4 2018, 2:25 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/hgweb/webutil.py (10 lines)

Diff 7622

mercurial/hgweb/webutil.py

return entries return entries
def cleanpath(repo, path): def cleanpath(repo, path):
path = path.lstrip('/') path = path.lstrip('/')
return pathutil.canonpath(repo.root, '', path) return pathutil.canonpath(repo.root, '', path)
def changeidctx(repo, changeid): def changeidctx(repo, changeid):
try: return repo[changeid]
ctx = repo[changeid]
except error.RepoError:
man = repo.manifestlog._revlog
ctx = repo[man.linkrev(man.rev(man.lookup(changeid)))]
return ctx
def changectx(repo, req): def changectx(repo, req):
changeid = "tip" changeid = "tip"
if 'node' in req.qsparams: if 'node' in req.qsparams:
changeid = req.qsparams['node'] changeid = req.qsparams['node']
ipos = changeid.find(':') ipos = changeid.find(':')
if ipos != -1: if ipos != -1:
changeid = changeid[(ipos + 1):] changeid = changeid[(ipos + 1):]
elif 'manifest' in req.qsparams:
changeid = req.qsparams['manifest']
return changeidctx(repo, changeid) return changeidctx(repo, changeid)
def basechangectx(repo, req): def basechangectx(repo, req):
if 'node' in req.qsparams: if 'node' in req.qsparams:
changeid = req.qsparams['node'] changeid = req.qsparams['node']
ipos = changeid.find(':') ipos = changeid.find(':')
if ipos != -1: if ipos != -1: