This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3080

localrepo: use revsymbol in lookupbranch() too
ClosedPublic

Authored by martinvonz on Apr 4 2018, 6:53 PM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHG92171562c7f3: localrepo: use revsymbol in lookupbranch() too
Summary

lookupbranch() takes a string that comes from the CLI, so
scmutil.revsymbol() is appropriate for looking it up.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Apr 4 2018, 6:53 PM
indygreg accepted this revision.Apr 4 2018, 8:45 PM
This revision is now accepted and ready to land.Apr 4 2018, 8:45 PM
Closed by commit rHG92171562c7f3: localrepo: use revsymbol in lookupbranch() too (authored by martinvonz). · Explain WhyApr 4 2018, 8:50 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/localrepo.py (2 lines)

Diff 7666

mercurial/localrepo.py

def lookup(self, key): def lookup(self, key):
return scmutil.revsymbol(self, key).node() return scmutil.revsymbol(self, key).node()
def lookupbranch(self, key): def lookupbranch(self, key):
if key in self.branchmap(): if key in self.branchmap():
return key return key
return self[key].branch() return scmutil.revsymbol(self, key).branch()
def known(self, nodes): def known(self, nodes):
cl = self.changelog cl = self.changelog
nm = cl.nodemap nm = cl.nodemap
filtered = cl.filteredrevs filtered = cl.filteredrevs
result = [] result = []
for n in nodes: for n in nodes:
r = nm.get(n) r = nm.get(n)