This is an archive of the discontinued Mercurial Phabricator instance.

perf: make perfmanifest and perfnodelookup work with revsets
ClosedPublic

Authored by martinvonz on Apr 4 2018, 6:53 PM.

Details

Summary

They were using repo[rev], which only works with a single symbol
(e.g. "." or "my-bookmark"), not general revsets. Switch them to
scmutil.revsingle() so they can also be used with e.g. ".^".

I don't actually care about these commands, but I want to remove uses
of repo[<string>].

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Apr 4 2018, 6:53 PM
indygreg accepted this revision.Apr 4 2018, 8:47 PM
This revision is now accepted and ready to land.Apr 4 2018, 8:47 PM
This revision was automatically updated to reflect the committed changes.