This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3085

children: support specifying revision by revset
ClosedPublic

Authored by martinvonz on Apr 4 2018, 6:53 PM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHG7c8524efd847: children: support specifying revision by revset
rHG8d4b063c2706: children: support specifying revision by revset
rHG3c5331915f0b: children: support specifying revision by revset
Summary

Same reason as the previous patch.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Apr 4 2018, 6:53 PM
indygreg added a subscriber: indygreg.Apr 4 2018, 8:48 PM

It would be nice to have tests for these changes to ensure we don't regress...

But progress is progress.

indygreg accepted this revision.Apr 4 2018, 8:49 PM
This revision is now accepted and ready to land.Apr 4 2018, 8:49 PM
Closed by commit rHG3c5331915f0b: children: support specifying revision by revset (authored by martinvonz). · Explain WhyApr 4 2018, 8:51 PM
This revision was automatically updated to reflect the committed changes.
martinvonz added a comment.Apr 5 2018, 12:52 AM
In D3085#49796, @indygreg wrote:

It would be nice to have tests for these changes to ensure we don't regress...
But progress is progress.

I spent about a minute or two trying to find a good test to update while writing D3084, but there didn't even seem to be one for hg heads <revision>, so I was lazy. Thanks for making me check tests for hg children, because that was actually easy - I've just sent D3120.

Revision Contents
Changeset List

PathPackages
Mhgext/children.py (5 lines)

Diff 7671

hgext/children.py

from __future__ import absolute_import from __future__ import absolute_import
from mercurial.i18n import _ from mercurial.i18n import _
from mercurial import ( from mercurial import (
cmdutil, cmdutil,
logcmdutil, logcmdutil,
pycompat, pycompat,
registrar, registrar,
scmutil,
) )
templateopts = cmdutil.templateopts templateopts = cmdutil.templateopts
cmdtable = {} cmdtable = {}
command = registrar.command(cmdtable) command = registrar.command(cmdtable)
# Note for extension authors: ONLY specify testedwith = 'ships-with-hg-core' for # Note for extension authors: ONLY specify testedwith = 'ships-with-hg-core' for
# extensions which SHIP WITH MERCURIAL. Non-mainline extensions should # extensions which SHIP WITH MERCURIAL. Non-mainline extensions should
hg children => hg log -r "children(.)" hg children => hg log -r "children(.)"
hg children -r REV => hg log -r "children(REV)" hg children -r REV => hg log -r "children(REV)"
See :hg:`help log` and :hg:`help revsets.children`. See :hg:`help log` and :hg:`help revsets.children`.
""" """
opts = pycompat.byteskwargs(opts) opts = pycompat.byteskwargs(opts)
rev = opts.get('rev') rev = opts.get('rev')
ctx = scmutil.revsingle(repo, rev)
if file_: if file_:
fctx = repo.filectx(file_, changeid=rev) fctx = repo.filectx(file_, changeid=ctx.rev())
childctxs = [fcctx.changectx() for fcctx in fctx.children()] childctxs = [fcctx.changectx() for fcctx in fctx.children()]
else: else:
ctx = repo[rev]
childctxs = ctx.children() childctxs = ctx.children()
displayer = logcmdutil.changesetdisplayer(ui, repo, opts) displayer = logcmdutil.changesetdisplayer(ui, repo, opts)
for cctx in childctxs: for cctx in childctxs:
displayer.show(cctx) displayer.show(cctx)
displayer.close() displayer.close()