( )⚙ D3083 perf: make perfmanifest and perfnodelookup work with revsets

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3083

perf: make perfmanifest and perfnodelookup work with revsets
ClosedPublic

Authored by martinvonz on Apr 4 2018, 6:53 PM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHG5bcd5859b505: perf: make perfmanifest and perfnodelookup work with revsets
Summary

They were using repo[rev], which only works with a single symbol
(e.g. "." or "my-bookmark"), not general revsets. Switch them to
scmutil.revsingle() so they can also be used with e.g. ".^".

I don't actually care about these commands, but I want to remove uses
of repo[<string>].

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Apr 4 2018, 6:53 PM
indygreg accepted this revision.Apr 4 2018, 8:47 PM
This revision is now accepted and ready to land.Apr 4 2018, 8:47 PM
Closed by commit rHG5bcd5859b505: perf: make perfmanifest and perfnodelookup work with revsets (authored by martinvonz). · Explain WhyApr 4 2018, 8:50 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mcontrib/perf.py (4 lines)

Diff 7669

contrib/perf.py

repo.manifestlog.clearcaches() repo.manifestlog.clearcaches()
repo.manifestlog[t].read() repo.manifestlog[t].read()
timer(d) timer(d)
fm.end() fm.end()
@command('perfchangeset', formatteropts) @command('perfchangeset', formatteropts)
def perfchangeset(ui, repo, rev, **opts): def perfchangeset(ui, repo, rev, **opts):
timer, fm = gettimer(ui, opts) timer, fm = gettimer(ui, opts)
n = repo[rev].node() n = scmutil.revsingle(repo, rev).node()
def d(): def d():
repo.changelog.read(n) repo.changelog.read(n)
#repo.changelog._cache = None #repo.changelog._cache = None
timer(d) timer(d)
fm.end() fm.end()
@command('perfindex', formatteropts) @command('perfindex', formatteropts)
def perfindex(ui, repo, **opts): def perfindex(ui, repo, **opts):
timer(lambda: len(revrange(repo, specs))) timer(lambda: len(revrange(repo, specs)))
fm.end() fm.end()
@command('perfnodelookup', formatteropts) @command('perfnodelookup', formatteropts)
def perfnodelookup(ui, repo, rev, **opts): def perfnodelookup(ui, repo, rev, **opts):
timer, fm = gettimer(ui, opts) timer, fm = gettimer(ui, opts)
import mercurial.revlog import mercurial.revlog
mercurial.revlog._prereadsize = 2**24 # disable lazy parser in old hg mercurial.revlog._prereadsize = 2**24 # disable lazy parser in old hg
n = repo[rev].node() n = scmutil.revsingle(repo, rev).node()
cl = mercurial.revlog.revlog(getsvfs(repo), "00changelog.i") cl = mercurial.revlog.revlog(getsvfs(repo), "00changelog.i")
def d(): def d():
cl.rev(n) cl.rev(n)
clearcaches(cl) clearcaches(cl)
timer(d) timer(d)
fm.end() fm.end()
@command('perflog', @command('perflog',